Merge pull request #299 from MyUnisoft/fix_connector_idAsString

fix(schema/events/connector): id is any string
MyUnisoft · Jan 15, 2025 · 581ac79 · 581ac79
2 parents 37e682c + 8af1351
commit 581ac79
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 23 deletions.
diff --git a/README.md b/README.md
@@ -79,7 +79,7 @@ const event: EventOptions<"connector"> = {
     createdAt: Date.now()
   },
   data: {
-    id: 1,
+    id: "1",
     code: "JFAC"
   }
 };

diff --git a/src/schema/events/connector.json b/src/schema/events/connector.json
@@ -4,8 +4,7 @@
       "type": "object",
       "properties": {
         "id": {
-          "type": "string",
-          "pattern": "^[0-9]+"
+          "type": "string"
         },
         "code": {
           "type": "string"
@@ -22,8 +21,7 @@
       "type": "object",
       "properties": {
         "id": {
-          "type": "string",
-          "pattern": "^[0-9]+"
+          "type": "string"
         },
         "code": {
           "type": "string"
@@ -40,8 +38,7 @@
       "type": "object",
       "properties": {
         "id": {
-          "type": "string",
-          "pattern": "^[0-9]+"
+          "type": "string"
         },
         "code": {
           "type": "string"

diff --git a/test/UT/index.test.ts b/test/UT/index.test.ts
@@ -54,22 +54,6 @@ describe("validate", () => {
     });
   });
 
-  test("Given a wrong property, it should throw", () => {
-    const event = {
-      name: "connector",
-      operation: "CREATE",
-      data: {
-        id: "foo",
-        code: "bar"
-      }
-    };
-
-    assert.throws(() => validate(event as any), {
-      name: "Error",
-      message: `data: [/id: must match pattern \"^[0-9]+\"]`
-    });
-  });
-
   test("Given a wrong metadata, it should throw", () => {
     const event = {
       name: "accountingFolder",
-Original file line number
+Diff line change
@@ Expand Up / @@ -79,7 +79,7 @@ const event: EventOptions<"connector"> = { @@
         createdAt: Date.now()
       },
       data: {
-        id: 1,
+        id: "1",
         code: "JFAC"
       }
     };
@@ Expand Down @@