Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: fixing ci for main branch and clarifying names #2

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

MykalMachon
Copy link
Owner

This pull request includes several changes to the GitHub Actions workflow configuration file .github/workflows/ci.yaml. The main changes involve renaming job steps and modifying Docker image tags.

Changes to job names and steps:

  • Added a name field to the build job to specify the job name as "Building".
  • Added a name field to the test job to specify the job name as "Testing".
  • Renamed the check created in the test job from "NGINX Test" to "Healthcheck".

Changes to Docker image tags:

  • Removed the conditional tag for the main branch in the build job, simplifying the tags to only include the commit SHA and branch name.

renaming jobs so that it's easier to tell what they're doing
@MykalMachon MykalMachon added the enhancement New feature or request label Dec 3, 2024
@MykalMachon MykalMachon self-assigned this Dec 3, 2024
@MykalMachon MykalMachon merged commit 6185d0f into main Dec 3, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant