Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update "blst" from "0.3.11" to "0.3.13" to fix build on x86 Mac #20921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Jan 18, 2025

Description

In order to successfully build on my Intel Mac I had to update a blst dependency to "0.3.13". With the version "0.3.11" I'm getting the following:

warning: blst@0.3.11: /var/folders/6v/s4b4wws53_j3ym0gc4wgmzqr0000gn/T/assembly-71e81e.s:8561:1: error: invalid CFI advance_loc expression
warning: blst@0.3.11: .cfi_adjust_cfa_offset 8
warning: blst@0.3.11: ^
warning: blst@0.3.11: ToolExecError: Command env -u IPHONEOS_DEPLOYMENT_TARGET "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-apple-darwin" "-mmacosx-version-min=15.2" "-Wall" "-Wextra" "-mno-avx" "-fno-builtin" "-Wno-unused-function" "-Wno-unused-command-line-argument" "-D__ADX__" "-o" "/var/folders/6v/s4b4wws53_j3ym0gc4wgmzqr0000gn/T/cargo-installTiPaPX/release/build/blst-36b169cb32bec89f/out/ef1d644edca660a8-assembly.o" "-c" "/Users/d/.cargo/registry/src/index.crates.io-6f17d22bba15001f/blst-0.3.11/blst/build/assembly.S" with args cc did not execute successfully (status code exit status: 1).

error: failed to run custom build command for `blst v0.3.11`

Caused by:
  process didn't exit successfully: `/var/folders/6v/s4b4wws53_j3ym0gc4wgmzqr0000gn/T/cargo-installTiPaPX/release/build/blst-e5a2897cd01ae6e7/build-script-build` (exit status: 1)
  --- stdout
  cargo:rustc-cfg=feature="std"
  cargo:rerun-if-env-changed=BLST_TEST_NO_STD
  Using blst source directory /Users/d/.cargo/registry/src/index.crates.io-6f17d22bba15001f/blst-0.3.11/blst
  cargo:rerun-if-changed=/Users/d/.cargo/registry/src/index.crates.io-6f17d22bba15001f/blst-0.3.11/blst/src
  cargo:rerun-if-changed=/Users/d/.cargo/registry/src/index.crates.io-6f17d22bba15001f/blst-0.3.11/blst/build

The problem was discussed there: ethereum/go-ethereum#30494.

Test plan

Running a current test suite.


Release notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 1:05am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 1:05am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 1:05am

@lexfrl lexfrl changed the title Update blst from 0.3.11 to 0.3.13 to fix build on x86 Mac Update "blst" from "0.3.11" to "0.3.13" to fix build on x86 Mac Jan 18, 2025
@lexfrl lexfrl temporarily deployed to sui-typescript-aws-kms-test-env January 18, 2025 19:41 — with GitHub Actions Inactive
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant