Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

comment out raise error message #3655

Merged
merged 1 commit into from
Aug 15, 2024
Merged

comment out raise error message #3655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/vdc/DCCF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,21 @@ int DCCF::initialize_impl(const vector<string> &paths, const std::vector<string>
// https://github.com/NCAR/VAPOR/issues/3626
// add a test if there's any 2D or 3D variables detected. If not, we raise an error.
//
auto vars2d = ncdfc->GetDataVariableNames(2, true);
if (vars2d.empty()) {
auto vars3d = ncdfc->GetDataVariableNames(3, true);
if (vars3d.empty()) {
SetErrMsg("Failed to detect any 2D or 3D variables.\n"
"Did you forget any coordinate files?\n");
return (-1);
}
}
// Update on 8/15/2024:
// It turns out that this error message is also raised with UGRID 2D data sets, when it
// shouldn't be raised (see issue 3650). Thus, Sam is commenting out this logic for
// release 3.9.3, and will come back to design a more robust method to address both
// issues 3626 and 3650.
//
// auto vars2d = ncdfc->GetDataVariableNames(2, true);
// if (vars2d.empty()) {
// auto vars3d = ncdfc->GetDataVariableNames(3, true);
// if (vars3d.empty()) {
// SetErrMsg("Failed to detect any 2D or 3D variables.\n"
// "Did you forget any coordinate files?\n");
// return (-1);
// }
// }

if (_ncdfc) {
delete _ncdfc;
Expand Down