228 hires #229
228 hires #229
Conversation
include/micm/solver/rosenbrock.hpp
Outdated
| @@ -189,7 +193,7 @@ namespace micm | |||
| /// @param rate_constants List of rate constants for each needed species | |||
| /// @param number_densities The number density of each species | |||
| /// @param forcing Vector of forcings for the current conditions | |||
| void CalculateForcing( | |||
| virtual void CalculateForcing( | |||
There was a problem hiding this comment.
is it necessary to make this virtual? it looks like you are using the extending class directly in the tests
There was a problem hiding this comment.
Well, when I didn't have virtual here, the functions I defined weren't called, I'll try removing this now and see if it breaks
There was a problem hiding this comment.
Yeah, removing virtual here broke the tests
There was a problem hiding this comment.
do you think it's worth using the set of processes we derived for the Oregonator test instead of extending RosebrockSolver? I'm just wondering if we want to change the solver class just for a test
There was a problem hiding this comment.
That's fine. I'll have to translate the HIRES and E5 equations though.
There was a problem hiding this comment.
oh, well maybe it's not worth the change then. we can just keep the virtual functions and always change later on if we want to
include/micm/solver/rosenbrock.hpp
Outdated
| @@ -210,7 +214,7 @@ namespace micm | |||
| /// @param rate_constants List of rate constants for each needed species | |||
| /// @param number_densities The number density of each species | |||
| /// @param jacobian The matrix of partial derivatives | |||
| void CalculateJacobian( | |||
| virtual void CalculateJacobian( | |||
Closes #228