Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding state default constructor test #734

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

K20shores
Copy link
Collaborator

Adds a test of the state's default constructor, fixes a memory error

Copy link
Collaborator

@sjsprecious sjsprecious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @K20shores for identifying and fixing this issue.

@sjsprecious sjsprecious self-assigned this Feb 21, 2025
@sjsprecious sjsprecious added the bug Something isn't working label Feb 21, 2025
@sjsprecious sjsprecious added this to the MICM Paper milestone Feb 21, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (e5346b3) to head (aa5e933).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   94.48%   94.50%   +0.02%     
==========================================
  Files          64       64              
  Lines        4408     4426      +18     
==========================================
+ Hits         4165     4183      +18     
  Misses        243      243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjsprecious sjsprecious merged commit c52cc22 into main Feb 21, 2025
26 checks passed
@sjsprecious sjsprecious deleted the state_default_constructor branch February 21, 2025 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants