MUSICA Tutorial Chapter 0 #173
Conversation
tutorial/CMakeLists.txt
Outdated
| target_include_directories(demo_c PUBLIC ${MUSICA_INCLUDE_DIR}) | ||
| target_link_directories(demo_c PUBLIC ${MUSICA_LIB_DIR}) | ||
|
|
||
| target_include_directories(demo_f PUBLIC ${MUSICA_INCLUDE_DIR}) | ||
| target_link_directories(demo_f PUBLIC ${MUSICA_LIB_DIR}) | ||
| target_link_libraries(demo_f musica-fortran musica stdc++) |
There was a problem hiding this comment.
Instead of using target_link_directories, could you use target_link_libraries as it is discouraged to use as stated in the docs? I also wonder whether you need them. When you just use target_link_librararies to link musica, does it fail?
There was a problem hiding this comment.
Hi @mattldawson, @K20shores, do you think we should add these demo_c and demo_f to the musica test suite?
There was a problem hiding this comment.
yes, I would add any tutorial code to the test suite
There was a problem hiding this comment.
Great, @dwfncar, could you make demo_* as a test?
There was a problem hiding this comment.
Without the target_link_directories I get the link errors /usr/bin/ld: cannot fine -lmusica-fortran (and -lmusica)
There was a problem hiding this comment.
Added demo.f90 as a unit test in fortran/test/unit/CMakeLists.txt, will add demo.c when it has actual content.
There was a problem hiding this comment.
hmm maybe instead oftutorial/ being the top level directory it might need to be a subdirectory offortran/ like micm? Then it could link to musica-fortran library. What do you think?
There was a problem hiding this comment.
Yeah, I would recommend the tutorial tests being in micm/fortran/test/tutorial and you should be able to just use the create_standard_fortran_test() macro (I think). That macro links tests against the musica-fortran library. Similar to this:
musica/fortran/test/unit/CMakeLists.txt
Lines 6 to 8 in 69bcb2e
| target_include_directories(demo_f PUBLIC ${MUSICA_INCLUDE_DIR}) | ||
| target_link_directories(demo_f PUBLIC ${MUSICA_LIB_DIR}) | ||
| target_link_libraries(demo_f musica-fortran musica stdc++) |
There was a problem hiding this comment.
Oops sorry, I missed it, could you remove target_link_directories(..)?
I also think you don't need to link to the musica library.
| target_include_directories(demo_f PUBLIC ${MUSICA_INCLUDE_DIR}) | |
| target_link_directories(demo_f PUBLIC ${MUSICA_LIB_DIR}) | |
| target_link_libraries(demo_f musica-fortran musica stdc++) | |
| target_include_directories(demo_f PUBLIC ${MUSICA_INCLUDE_DIR}) | |
| target_link_libraries(demo_f PRIVATE musica::musica-fortran) |
Added Chapter 0 tutorial describing a CMakeLists.txt to link to the musica-fortran library.