-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
81 supply custom rate constants to fortran #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor suggestion
@@ -11,7 +11,7 @@ include(FetchContent) | |||
|
|||
FetchContent_Declare(musica-fortran | |||
GIT_REPOSITORY https://github.com/NCAR/musica.git | |||
GIT_TAG 79-allow-updates-to-custom-rate-constant-parameters-and-mapping-by-name | |||
GIT_TAG 81-supply-custom-rate-constants-to-fortran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this need to be updated to main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, though that will cause the tests to fail for now
Closes #81