Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

81 supply custom rate constants to fortran #82

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

K20shores
Copy link
Collaborator

Closes #81

@K20shores K20shores linked an issue Apr 3, 2024 that may be closed by this pull request
@K20shores K20shores marked this pull request as ready for review April 3, 2024 16:47
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor suggestion

@@ -11,7 +11,7 @@ include(FetchContent)

FetchContent_Declare(musica-fortran
GIT_REPOSITORY https://github.com/NCAR/musica.git
GIT_TAG 79-allow-updates-to-custom-rate-constant-parameters-and-mapping-by-name
GIT_TAG 81-supply-custom-rate-constants-to-fortran
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this need to be updated to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, though that will cause the tests to fail for now

@K20shores K20shores merged commit 2ffaaa0 into main Apr 5, 2024
31 of 34 checks passed
@K20shores K20shores deleted the 81-supply-custom-rate-constants-to-fortran branch April 5, 2024 16:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply custom rate constants to fortran
3 participants