Read ZSOIL8 from HYDRO_nlist if sys_cpl ne 1 #578
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: ZSOIL8, HYDRO_nlist, config
SOURCE: @danrosen25 NCAR
DESCRIPTION OF CHANGES: This fixes an issue where the user cannot specify the soil depths (a.k.a. soil layer thickness) in configuration files during coupled runs. If the sys_cpl type does not equal 1 the initialization routine will read ZSOIL8 from the HYDRO_nlist namelist in the hydro.namelist file. This may is not fully backwards compatible because previous coupling applications may have relied on hardcoded soil depths.
ISSUE: #571
TESTS CONDUCTED: I tested using sys_cpl=2 in a coupled LIS-WRFHYDRO application using NUOPC infrastructure.
Checklist
NEWS.md