Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(module:*): migrate the source code to Angular v10 #5494

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jul 1, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #5494 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5494   +/-   ##
=======================================
  Coverage   91.15%   91.16%           
=======================================
  Files         453      453           
  Lines       13880    13901   +21     
  Branches     2206     2210    +4     
=======================================
+ Hits        12653    12673   +20     
- Misses        727      728    +1     
  Partials      500      500           
Impacted Files Coverage Δ
components/affix/affix.module.ts 100.00% <ø> (ø)
components/anchor/anchor.module.ts 100.00% <ø> (ø)
components/back-top/back-top.module.ts 100.00% <ø> (ø)
components/core/services/scroll.ts 68.75% <ø> (-1.84%) ⬇️
...omponents/date-picker/lib/abstract-panel-header.ts 88.63% <ø> (ø)
components/date-picker/lib/abstract-table.ts 89.28% <ø> (ø)
components/timeline/timeline.service.ts 100.00% <ø> (ø)
components/tooltip/base.ts 92.72% <100.00%> (-0.35%) ⬇️
components/tooltip/tooltip.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074a3da...e0e8418. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the refactor/migration-v10 branch from aab27d5 to cfab9e8 Compare July 1, 2020 08:39
@hsuanxyz hsuanxyz requested a review from vthinkxie July 1, 2020 12:49
vthinkxie
vthinkxie previously approved these changes Jul 1, 2020
wzhudev
wzhudev previously approved these changes Jul 1, 2020
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz dismissed stale reviews from wzhudev and vthinkxie via e0e8418 July 2, 2020 01:55
@hsuanxyz hsuanxyz force-pushed the refactor/migration-v10 branch from cfab9e8 to e0e8418 Compare July 2, 2020 01:55
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants