Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[0.13] Don’t try to revoke child keys for non-existing resource classes. #1207

Merged
merged 2 commits into from
Jun 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/daemon/ca/certauth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,15 @@ impl CertAuth {
fn child_revoke_key(&self, child_handle: ChildHandle, request: RevocationRequest) -> KrillResult<Vec<CaEvt>> {
let (rcn, key) = request.unpack();

if !self.resources.contains_key(&rcn) {
// This request is for a resource class we don't have. We should
// not get such requests but telling this to a child may confuse
// them more, so just return with an empty vec of events - there
// is no work to do - and ensure that the child just gets a
// confirmation where this is called.
return Ok(vec![])
}

let child = self.get_child(&child_handle)?;

if !child.is_issued(&key) {
Expand Down
Loading