-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ILoggingBuilder AddNLog extension method with correct dispose and no double logging #325
ILoggingBuilder AddNLog extension method with correct dispose and no double logging #325
Conversation
Should probably also make a PR for NLog.Web.AspNetCore so it will also work correctly there. |
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=========================================
+ Coverage 81.05% 81.56% +0.5%
=========================================
Files 12 12
Lines 1098 1101 +3
Branches 193 194 +1
=========================================
+ Hits 890 898 +8
+ Misses 143 139 -4
+ Partials 65 64 -1
Continue to review full report at Codecov.
|
666061f
to
5def637
Compare
5def637
to
e8543ed
Compare
@304NotModified Milestone has to be 1.5.4. See also: https://www.nuget.org/packages/NLog.Extensions.Logging/1.5.3 |
Sharp! Thanks! 1.5.3 milestone/github release fixed! |
Created NLog/NLog.Web#459 for NLog.Web.AspNetCore (waits for the 1.5.4 release) |
👍 |
Resolves #324 for ILoggingBuilder. But will NOT help #254 for
ILoggerFactory
.Fixes lifetime issue found in NLog/NLog#3284 where calling
ILoggingBuilder.AddNLog
caused NLogLoggingProvider not being disposed correctly on application shutdown (No flush and shutdown).