-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add pip and npm & better handle auxiliary PMs #18
Conversation
setup
Outdated
@@ -266,6 +268,12 @@ superbbootstrap_AUR() { | |||
fi | |||
} | |||
|
|||
superbbootstrap_PIP() { | |||
pip install pip --upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many Linux distros system Python has no pip
module installed so the this command should be:
python3 -m ensurepip
And even if it does have pip
module, it's executable could be not on the $PATH, so the package install command should look like this:
python3 -m pip install --upgrade <package_name>
The --upgrade
option tells it not to reinstall the package if it is already installed.
8fcf7d4 should fix this. |
I understood something and switched back to the old way auxiliary PMs were handled. The PM_check variable was removed. |
setup
Outdated
npm install npm@latest -g | ||
} | ||
|
||
superbbootstrap_PIP() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opss, will fix to superbbootstrap_Python
PACKAGEMANAGER_LIST="$PACKAGEMANAGER_LIST Flatpak" | ||
PACKAGEMANAGER_LIST="$PACKAGEMANAGER_LIST Homebrew" | ||
|
||
PACKAGEMANAGER_LIST="$PACKAGEMANAGER_LIST Flatpak Homebrew" | ||
|
||
if [ "$PACKAGEMANAGER_MAIN" = 'APT' ] || [ "$PACKAGEMANAGER_MAIN" = 'Pacman' ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snap
can only be install with apt
and aur
in all current supported package managers
setup
Outdated
@@ -179,8 +185,6 @@ superbbootstrap_install_packages() { | |||
fi | |||
|
|||
for packagemanager in $PACKAGEMANAGER_LIST; do | |||
printf '\n\033[1;7;35m%s\033[0m\n' "Checking for packages from $packagemanager" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This print is unnecessary because
eval "mark=\"\$${packagemanager}_MARK\""
eval "install_command=\"\$${packagemanager}_COMMAND\""
is not even take 1 second to runned.
No description provided.