Ww3 gse #1076
Closed
Ww3 gse #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: model/src/w3profsmd_pdlib.F90
…dd manual comments.
…After mergin with ww3_difraction the subroutine for the differentation will be removed at the given place.
…ure there will be more work, since it is all tested on global setup.
|
Hi @aronroland, It's great to see this PR for unstructured GSE! I saw you mention a global domain test case you wanted to discuss with us for a regtest. Let us know when you want to go over that. There are a few PR's ahead of this one, I'm starting on #1070 today. |
MatthewMasarik-NOAA
requested changes
Sep 20, 2023
There was a problem hiding this comment.
@aronroland These are the outstanding changes for you to follow up on:
- Current regtests have been run to demonstrate no issues introduced.
- Regtest added to demonstrate the feature. If you'd like to discuss the details, please contact Jessica and I at your convenience.
|
@aronroland please sync for the latest merge, #1070. |
|
@thesser1 @aronroland fyi, this branch needs syncing as well |
|
Closing on behalf of @thesser1 and @aronroland. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
see #886
Description
This pull requests introduces the GSE correction on unstructured grids using an iterative explicit galerkin approach to solve the anistotropic diffusion equation. The diffusion tensor is computed in the same way as for structured grid.
Please also include the following information:
This is a new_feature and when turned of it will not change any of the results of the regtests.
Issue(s) addressed
#886
Commit Message
GSE alleviation for unstructured grids
Check list
Testing
As for the regression tests, Ali and me have some global setup but we need to clarify this with the code managers if this would be the test to add. Regression testing is going to be done on ERDC side, but no changes to the results are expected.