Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Developer Issue]: code coverage not getting calculated for pull requests #605

Closed
iantaylor-NOAA opened this issue May 28, 2024 · 2 comments · Fixed by #611
Closed

[Developer Issue]: code coverage not getting calculated for pull requests #605

iantaylor-NOAA opened this issue May 28, 2024 · 2 comments · Fixed by #611
Labels
kind: bug Something isn't working

Comments

@iantaylor-NOAA
Copy link
Contributor

Issue details

The code coverage of Pull Requests is calculated in order to confirm that coverage remains high after the change in the PR. However none of the PRs in the past month have had a successful calculation of the code coverage metric: https://app.codecov.io/gh/NOAA-FIMS/FIMS/pulls.

The message provided by codecov is

Missing Head Commit
Unable to compare commits because the head commit of the pull request is not found.
Learn more here

where that link says the error can be caused by "not yet uploaded coverage results to Codecov".

I'm confused about the combination of code coverage workflows for gtest and testthat (discussed in #242) so I'm not sure where to look for a solution.
Did something change?

@iantaylor-NOAA iantaylor-NOAA added the status: triage_needed This is not approved for this milestone, do not work on it yet label May 28, 2024
@k-doering-NOAA k-doering-NOAA self-assigned this May 29, 2024
@k-doering-NOAA k-doering-NOAA added kind: bug Something isn't working and removed status: triage_needed This is not approved for this milestone, do not work on it yet labels May 29, 2024
@k-doering-NOAA
Copy link
Member

Thanks for reporting this @iantaylor-NOAA - I can look into this and see what's going on.

@k-doering-NOAA
Copy link
Member

It looks like codecov now requires an upload token in order to upload reports. See this issue on the rlib actions. What is happening is that the reports being generated for gtest and testthat are not being successfully uploaded to codecov.io due to the lack of an upload token.

I'm working on adding an upload token to the FIMS repo and then referencing it in the 2 workflows.

k-doering-NOAA added a commit that referenced this issue May 29, 2024
This is necessary because changes were made to
codecov.io so that a token is required to upload.
@k-doering-NOAA k-doering-NOAA linked a pull request May 29, 2024 that will close this issue
1 task
k-doering-NOAA added a commit that referenced this issue May 31, 2024
This is necessary because changes were made to
codecov.io so that a token is required to upload.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants