-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Developer Issue]: code coverage not getting calculated for pull requests #605
Comments
Thanks for reporting this @iantaylor-NOAA - I can look into this and see what's going on. |
It looks like codecov now requires an upload token in order to upload reports. See this issue on the rlib actions. What is happening is that the reports being generated for gtest and testthat are not being successfully uploaded to codecov.io due to the lack of an upload token. I'm working on adding an upload token to the FIMS repo and then referencing it in the 2 workflows. |
This is necessary because changes were made to codecov.io so that a token is required to upload.
This is necessary because changes were made to codecov.io so that a token is required to upload.
Issue details
The code coverage of Pull Requests is calculated in order to confirm that coverage remains high after the change in the PR. However none of the PRs in the past month have had a successful calculation of the code coverage metric: https://app.codecov.io/gh/NOAA-FIMS/FIMS/pulls.
The message provided by codecov is
where that link says the error can be caused by "not yet uploaded coverage results to Codecov".
I'm confused about the combination of code coverage workflows for gtest and testthat (discussed in #242) so I'm not sure where to look for a solution.
Did something change?
The text was updated successfully, but these errors were encountered: