Pass specs file name to fieldData class #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with authoritative
Allows users to specify which UPP fields are used when making various plots by creating their own default_specs.yml that can be passed to pygraf using the --specs option.
ShawnMurdzek-NOAA
requested review from
cshartsough,
christinaholtNOAA,
Brian-Jamison,
kayeekayee and
jaymes-kenyon
as code owners
christinaholtNOAA
approved these changes
Jan 31, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_specs.ymlfile controls which fields are extracted from the UPP GRIB2 output for plotting as well as the plotting specifications. When using a custom version ofdefault_specs.ymlwith the--specsoption, information about which UPP fields to extract are not passed to theadb_graphics.datahandler.gribdata.fieldDataclass as expected. Instead, the default values are always used.This PR addresses this bug by making a few, minor changes to pass the user-defined specs file to
adb_graphics.datahandler.gribdata.fieldData.Test: Offline using UPP output with fields following a mix of HRRR and RRFS naming conventions. Updated code successfully leveraged a user-defined specs file so that the correct fields were plotted.