-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[1pt] PR: Modified HUC processing duration system #1401
Conversation
oops... found a bug. If a branch fails and the branch log file does not exists, the entire system crashes. I suggest, just dropping that branch log data in the total logs counts. |
Merge remote-tracking branch 'origin/dev' into dev-duration
Thanks Rob! This script saves the log file for each HUC as we discussed. So, I added a line to solve that issue for failed HUC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is soooo cool and a huge help for me. Major Thanks. Rob
…into dev-duration
This PR improves the current HUC processing duration system by saving the processing time for each HUC separately. This helps prevent collisions that can happen during parallel processing and ensures more accurate, comprehensive results. The new Python script reads all the processing time files and combines them into a CSV. It also adds a summary line at the end with the total runtime, as well as the number of HUCs and branches.
Additions
src/duration_system.py
: This is a new script that reads duration files for each huc and concatenates them into a csv.Changes
src/run_unit_wb.sh
: Recorded the processing time for branch 0 and saved a separate file for each huc.fim_post_processing.sh
: Added new lines to execute the new script.Removals
Testing
Tested for HUCs
05030104
and10240004
.Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)