Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

stuck in city on load game #1170

Closed
xDjura opened this issue Jun 9, 2019 · 4 comments
Closed

stuck in city on load game #1170

xDjura opened this issue Jun 9, 2019 · 4 comments
Milestone

Comments

@xDjura
Copy link

xDjura commented Jun 9, 2019

Description of Problem or Question

If I save the game while in the city/shop screen, after loading the save shop UI is gone and I am unable to proceed with the campaign.

Steps to reproduce:

  1. Start Shadow Rune campaign
  2. Finish first quest
  3. Enter city
  4. Save game
  5. Load game

Valkyrie Version

2.3.04

Attach Save, Quest or Scenario

Log File:
output_log.txt
Saves:
save2.zip

@MrTantum
Copy link

MrTantum commented Jun 9, 2019

I could reproduce the bug. It only seems to happen if you save inside of the city.

Please add all further bug reports in the official shadown rune repository: https://github.com/DelphiDie/TheShadowRune/issues

@DelphiDie could you have a look at this.

This could also be a general Valkyrie bug.

@DelphiDie
Copy link

Sorry, I can't do anything to fix this, but I added some information about the bug to #842

It seems to be related to this issue.

@NPBruce NPBruce modified the milestones: 2.5, 2.4 Aug 8, 2019
@NPBruce
Copy link
Owner

NPBruce commented Aug 8, 2019

Looks like this was caused by a change to the ini reader to treat '#' as a comment. Typically ';' is a comment in ini files so I'm looking into why this is changed.

@NPBruce
Copy link
Owner

NPBruce commented Aug 8, 2019

Fixed in 2.4, but unfortunately not for existing saves. I haven't addressed the underlying behaviour, so other odd places may break due to the '#' comment.

@NPBruce NPBruce closed this as completed Aug 8, 2019
NPBruce added a commit that referenced this issue Aug 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants