[WIP] Update InterconnectingConverter and HVDC structs #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 84.59% 84.55% -0.05%
==========================================
Files 181 181
Lines 8379 8389 +10
==========================================
+ Hits 7088 7093 +5
- Misses 1291 1296 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
reviewed
Aug 5, 2024
| "validation_action": "warn" | ||
| }, | ||
| { | ||
| "name": "dc_current_limits", |
There was a problem hiding this comment.
use a single quantity for absolute value.
rodrigomha
commented
Aug 5, 2024
| "validation_action": "warn" | ||
| }, | ||
| { | ||
| "name": "dc_current_limits", |
There was a problem hiding this comment.
change limits to dc_current_maximum
rodrigomha
changed the title
jd-lara
approved these changes
Oct 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until we are ready in implementing all constraints in PSI
Tests are passing locally with:
NREL-Sienna/PowerSystemCaseBuilder.jl#105
NREL-Sienna/PowerSystemsTestData#61