-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bugfix: Table Data Parser can have undefined inputs #1186
bugfix: Table Data Parser can have undefined inputs #1186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 84.55% 84.52% -0.03%
==========================================
Files 181 181
Lines 8389 8389
==========================================
- Hits 7093 7091 -2
- Misses 1296 1298 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ymiftah , if you add an empty |
With an empty
Truncated output
PS: I do not have a fully/correctly defined set of csv yet (working around this issue #1185) , so i actually ran this with empty generators and loads csv files as well. PPS: It would still throw an error without this bugfix |
b64e36c
to
9ca67d5
Compare
Background
When defining my system through CSV, without any dc_branch.csv, the TableData parser failed to create the system.
Bug description
The CSV files are parsed iteratively, with the
get_dataframe
function reading the TableData as a dataframethe
get_dataframe
function defaults to an empty dataframe if the InputCategory is not defined, not anothing
. The check should be alignedHappy to provide more context in an issue linked to this