Close multiple simple issues in PSY #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Sep 13, 2024
| @@ -13,7 +13,6 @@ The `PowerSystems.jl` package provides a rigorous data model using Julia structu | |||
| ## Version Advisory | |||
|
|
|||
| - PowerSystems will work with Julia v1.6+. | |||
| - If you are planning to use `PowerSystems.jl` in your package, check the [roadmap to version 4.0](https://github.com/NREL-Sienna/PowerSystems.jl/projects/4) for upcoming changes | |||
jd-lara
approved these changes
Sep 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 180 180
Lines 8264 8264
=======================================
Hits 6994 6994
Misses 1270 1270
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GabrielKS
requested changes
Sep 13, 2024
src/parsers/power_models_data.jl
Outdated
| @@ -346,9 +345,15 @@ function read_loadzones!( | |||
| load_zone_map[zone]["pd"] += get(load, "py", 0.0) | |||
| load_zone_map[zone]["qd"] += get(load, "qy", 0.0) | |||
| end | |||
|
|
|||
| default_loadzone_naming = x -> string(x) | |||
There was a problem hiding this comment.
Suggested change
| default_loadzone_naming = x -> string(x) | |
| default_loadzone_naming = string |
|
|
||
| default_loadzone_naming = x -> string(x) | ||
| # The formatter for loadzone_name should be a function that transform the LoadZone Int to a String | ||
| _get_name = get(kwargs, :loadzone_name_formatter, default_loadzone_naming) |
There was a problem hiding this comment.
Can we get unit tests for this?
GabrielKS
requested changes
Sep 16, 2024
test/test_parse_psse.jl
Outdated
| "psse_Benchmark_4ger_33_2015_sys"; | ||
| loadzone_name_formatter = x -> string(3 * x), | ||
| ) | ||
| lz_original = first(get_components(LoadZone, sys2)) |
There was a problem hiding this comment.
I don't think you can safely assume that the result of get_components will be in the same order every time. Maybe get all the LoadZone names in each, sort those lists, and compare the lists?
There was a problem hiding this comment.
There is only one load zone for that system, that's why I can use first
GabrielKS
reviewed
Sep 16, 2024
test/test_parse_psse.jl
Outdated
| "psse_Benchmark_4ger_33_2015_sys"; | ||
| loadzone_name_formatter = x -> string(3 * x), | ||
| ) | ||
| lz_original = first(get_components(LoadZone, sys2)) |
There was a problem hiding this comment.
nitpick:
Suggested change
| lz_original = first(get_components(LoadZone, sys2)) | |
| lz_original = only(get_components(LoadZone, sys2)) |
GabrielKS
reviewed
Sep 16, 2024
test/test_parse_psse.jl
Outdated
| loadzone_name_formatter = x -> string(3 * x), | ||
| ) | ||
| lz_original = first(get_components(LoadZone, sys2)) | ||
| lz_new = first(get_components(LoadZone, sys3)) |
There was a problem hiding this comment.
Suggested change
| lz_new = first(get_components(LoadZone, sys3)) | |
| lz_new = only(get_components(LoadZone, sys3)) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1175 via 692dfe0
Closes #1165 via 9dd3ef2
Closes #1162 via a62741c
Closes #1147 via 676e777
Closes #1160 via d954dee