add units to set variable cost #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
update MarketBidCost to new interface of set_variable_cost
NREL-Sienna/PowerSystemCaseBuilder.jl#109
Open
jd-lara
reviewed
Sep 30, 2024
| @@ -498,8 +498,8 @@ function thermal_generators_market_bid_ts(sys, node) | |||
|
|
|||
| PSY.add_component!(sys, gen1) | |||
| PSY.add_component!(sys, gen2) | |||
| PSY.set_variable_cost!(sys, gen1, market_bid_gen1) | |||
| PSY.set_variable_cost!(sys, gen2, market_bid_gen2) | |||
| PSY.set_variable_cost!(sys, gen1, market_bid_gen1, PSY.UnitSystem.NATURAL_UNITS) | |||
There was a problem hiding this comment.
@GabrielKS should we just default this to NaturalUnits on the PSY side?
|
we can merge this but it isn't a requirement. |
If we went with the plan I'm remembering, let's merge it to prevent the warning. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new set variable cost interface