Skip to content

Commit

Permalink
Added unit tests and updated IO and Eng Ref documentations (Issue #6151)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nigusse committed Jun 16, 2017
1 parent fe928ab commit 37fb236
Showing 3 changed files with 320 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -39,6 +39,8 @@ \subsection{Night Cycle}\label{night-cycle}

\item Thermostat on/off tolerance \emph{T\(_{tol}\)} (degrees C);

\item Cycling run time control type: \emph{FixedRunTime}, \emph{Thermostat}, or \emph{ThermostatWithMinimumRunTime};

\item Cycling run time in seconds; used to calculate a stop time (in time steps since the start of the current run period) once the status has become \emph{Cycle On}.

\item A control zone or zone list name.
@@ -56,11 +58,11 @@ \subsection{Night Cycle}\label{night-cycle}
Otherwise:

\begin{enumerate}
\item If current time (in time steps since the start of the run period) is greater than the start time and less than the stop time, \emph{AvailStatus = CycleOn} (or \emph{CycleOnZoneFansOnly} if the control type is \emph{Cycle On Any -- Zone Fans only}).
\item If current time (in time steps since the start of the run period) is greater than the start time and less than the stop time, \emph{AvailStatus = CycleOn} (or \emph{CycleOnZoneFansOnly} if the control type is \emph{Cycle On Any -- Zone Fans only}) for CyclingRunTimeControlType = \emph{CyclingRunTimeControlType = FixedRunTime}, or \emph{CyclingRunTimeControlType = ThermostatWithMinimumRunTime} but for \emph{CyclingRunTimeControlType = Thermostat} the availability status is determined based on the zone air and the thermostat setpoint temperature difference and the tolerance limits.

\item If the current time equals the stop time, \emph{AvailStatus = NoAction} ~and the fan schedule will determine if the system is on.
\item If the current time equals the stop time and the CyclingRunTimeControlType = \emph{CyclingRunTimeControlType = FixedRunTime}, or \emph{CyclingRunTimeControlType = ThermostatWithMinimumRunTime}, \emph{AvailStatus = NoAction} ~and the fan schedule will determine if the system is on. For \emph{CyclingRunTimeControlType = Thermostat} the availability status is determined based on the zone air and the thermostat setpoint temperature difference and the tolerance limits, and the fan schedule will determine if the system is on.

\item If the current time is greater than the stop time, the manager can potentially cycle the system on.
\item If the current time is greater than the stop time, the manager can potentially cycle the system on for \emph{CyclingRunTimeControlType = FixedRunTime}, \emph{CyclingRunTimeControlType = Thermostat}, or \emph{CyclingRunTimeControlType = ThermostatWithMinimumRunTime}.

\begin{enumerate}
\item For control types \emph{CycleOnAny} and \emph{CycleOnAnyZoneFansOnly} the manger looks at each zone served by the air loop and detects whether the zone temperature at the thermostat is greater than the cooling setpoint plus ½\emph{T\(_{tol}\)} or less than the heating setpoint minus ½\emph{T\(_{tol}\)}. If it is, \emph{AvailStatus} is set to \emph{CycleOn} (or \emph{CycleOnZoneFansOnly}). If not, \emph{AvailStatus} is set to \emph{NoAction}.
Original file line number Diff line number Diff line change
@@ -169,9 +169,9 @@ \subsubsection{Inputs}\label{inputs-3-037}

\begin{itemize}
\tightlist
\item \emph{FixedRunTime} cycling run time control mode the AvailabilityManager:NightCycle activates an airloop or zone equipment for a fixed amount of run time when the zone air temperature is one half the Thermostat Tolerance above the thermostat cooling setpoint or when the zone air temperature is one half the Thermostat Tolerance below the thermostat heating setpoint.
\item \emph{Thermostat} cycling run time control mode the AvailabilityManager:NightCycle activates an airloop or zone equipment until the zone air temperature is within 0.05 C above the thermostat cooling setpoint in cooling mode or until the zone air temperature is within 0.05 C below the thermostat heating setpoint in heating mode.
\item \emph{ThermostatWithMinimumRunTime} cycling run time control mode the AvailabilityManager:NightCycle activates an airloop or zone equipment for the specified minimum Cycling Run Time when the zone air temperature is with in 0.05 C above the thermostat cooling setpoint or when the zone air temperature is within 0.05 C below the thermostat heating setpoint and then continues running until the zone air temperature reaches the thermostat setpoint.
\item \emph{FixedRunTime} cycling run time control type the AvailabilityManager:NightCycle activates an airloop or zone equipment for a fixed amount of run time when the zone air temperature is one half of the Thermostat Tolerance above the thermostat cooling setpoint or when the zone air temperature is one half of the Thermostat Tolerance below the thermostat heating setpoint.
\item \emph{Thermostat} cycling run time control type the AvailabilityManager:NightCycle activates an airloop or zone equipment until the zone air temperature is within 0.05 deg C above the thermostat cooling setpoint in cooling mode or until the zone air temperature is within 0.05 deg C below the thermostat heating setpoint in heating mode. Cycling Run Time input field below is not used for this cycling run time control type.
\item \emph{ThermostatWithMinimumRunTime} cycling run time control type the AvailabilityManager:NightCycle activates an airloop or zone equipment for the specified minimum Cycling Run Time when the zone air temperature is with in 0.05 deg C above the thermostat cooling setpoint or when the zone air temperature is within 0.05 deg C below the thermostat heating setpoint and then continues running beyond the minimum Cycling Run Time until the zone air temperature reaches the thermostat setpoint within 0.05 deg C thermostat tolerance.
\end{itemize}

\paragraph{Field: Cycling Run Time}\label{field-cycling-run-time}
Loading

8 comments on commit 37fb236

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-MacOS-10.9-clang: OK (2488 of 2502 tests passed, 582 test warnings)

Messages:

  • 596 tests had: AUD diffs.
  • 22 tests had: Table small diffs.
  • 14 tests had: Table big diffs.

Failures:

regression Test Summary

  • Passed: 582
  • Failed: 14

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2528 of 2542 tests passed, 586 test warnings)

Messages:

  • 600 tests had: AUD diffs.
  • 22 tests had: Table small diffs.
  • 14 tests had: Table big diffs.

Failures:

regression Test Summary

  • Passed: 602
  • Failed: 14

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1308 of 1308 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1909 of 1909 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - i386-Windows-7-VisualStudio-14: OK (2492 of 2508 tests passed, 583 test warnings)

Messages:

  • 599 tests had: AUD diffs.
  • 23 tests had: Table small diffs.
  • 1 test had: ERR diffs.
  • 3 tests had: EIO diffs.
  • 2 tests had: ESO big diffs.
  • 2 tests had: MTR big diffs.
  • 16 tests had: Table big diffs.

Failures:

regression Test Summary

  • Passed: 583
  • Failed: 16

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - Win64-Windows-7-VisualStudio-14: OK (2493 of 2508 tests passed, 584 test warnings)

Messages:

  • 599 tests had: AUD diffs.
  • 23 tests had: Table small diffs.
  • 2 tests had: EIO diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTR big diffs.
  • 15 tests had: Table big diffs.

Failures:

regression Test Summary

  • Passed: 584
  • Failed: 15

Build Badge Test Badge

Please # to comment.