Skip to content

Commit

Permalink
Fix #8066 - Also add the proper units for the sizing for COilCoolingD…
Browse files Browse the repository at this point in the history
…XCurveFitOperatingMode
  • Loading branch information
jmarrec committed Sep 2, 2020
1 parent 22b30cb commit be73663
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
bool PrintFlag = true;

int SizingMethod = DataHVACGlobals::CoolingAirflowSizing;
std::string SizingString = "Rated Evaporator Air Flow Rate";
std::string SizingString = "Rated Evaporator Air Flow Rate [m3/s]";
Real64 TempSize = this->original_input_specs.rated_evaporator_air_flow_rate;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
this->ratedEvapAirFlowRate = TempSize;
Expand All @@ -170,7 +170,7 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
DataEnvironment::StdBaroPress, ratedInletAirTemp, ratedInletAirHumRat, RoutineName);

SizingMethod = DataHVACGlobals::CoolingCapacitySizing;
SizingString = "Rated Gross Total Cooling Capacity";
SizingString = "Rated Gross Total Cooling Capacity [W]";
DataSizing::DataFlowUsedForSizing = this->ratedEvapAirFlowRate; // TODO: This is volume flow, right?
TempSize = this->original_input_specs.gross_rated_total_cooling_capacity;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
Expand All @@ -180,7 +180,7 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
// Auto size condenser air flow to Total Capacity * 0.000114 m3/s/w (850 cfm/ton)
DataSizing::DataConstantUsedForSizing = this->ratedGrossTotalCap;
DataSizing::DataFractionUsedForSizing = 0.000114;
SizingString = "Rated Condenser Air Flow Rate";
SizingString = "Rated Condenser Air Flow Rate [m3/s]";
TempSize = this->original_input_specs.rated_condenser_air_flow_rate;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
this->ratedCondAirFlowRate = TempSize;
Expand Down

6 comments on commit be73663

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - x86_64-MacOS-10.15-clang-11.0.0: OK (2830 of 2925 tests passed, 0 test warnings)

Messages:\n

  • 11 tests had: EIO diffs.
  • 11 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 705
  • Failed: 11

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2869 of 2965 tests passed, 0 test warnings)

Messages:\n

  • 12 tests had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 12 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 724
  • Failed: 12

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (13 of 13 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1407 of 1491 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2100 of 2184 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8066_CoilDXCurveOperatingMode_Sizing (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (721 of 721 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please # to comment.