Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up daylighting output reporting for more than two reference points #6976

Closed
3 tasks
JasonGlazer opened this issue Sep 20, 2018 · 0 comments · Fixed by #8017
Closed
3 tasks

Clean up daylighting output reporting for more than two reference points #6976

JasonGlazer opened this issue Sep 20, 2018 · 0 comments · Fixed by #8017
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@JasonGlazer
Copy link
Contributor

While working on #6889 found that in the DaylightingManager ::CalcDayltgCoefficients() routine, saw that some output reports seems to be tied to the number of daylighting reference points. These need to be cleaned up after the release goes out since they impact output report format. This code is used when writing to OutputFileInits and to OutputFileDFS.

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@JasonGlazer JasonGlazer added the Defect Includes code to repair a defect in EnergyPlus label Sep 20, 2018
jmarrec added a commit that referenced this issue May 27, 2020
@jmarrec
Fix #6976
f43ca39
@jmarrec jmarrec mentioned this issue May 27, 2020
Merged
20 tasks
jmarrec added a commit that referenced this issue Jun 3, 2020
@jmarrec
Add unit test for #6976 to test DFS/EIO output
a6f2417
jmarrec added a commit that referenced this issue Jun 4, 2020
@jmarrec
#6976 - Address review comment to conform to EIO format.
0f1f427
Myoldmopar added a commit that referenced this issue Jun 5, 2020
@Myoldmopar
Merge pull request #8017 from NREL/6976_DaylightingOutput
92fa7d9 
Fix #6976 - Clean up daylighting output reporting for more than two reference points
@mitchute mitchute mentioned this issue Jun 8, 2020
Merged
20 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6976 - Clean up daylighting output reporting for more than two reference points NREL/EnergyPlus
1 participant
@JasonGlazer