Address zone air terminal zone outdoor air flow rate reporting issues #7955

Nigusse · 2020-04-29T21:29:14Z

Pull request overview

Fixes AirTerminal:SingleDuct:ConstantVolume:NoReheat Zone Air Terminal Outdoor Air Volume Flow Rate always zero #7950
Fixes the Zone Air Terminal Outdoor Air Volume Flow Rate reporting issues for single duct constant volume with and with NoReheat air terminals.
Zone Air Terminal Outdoor Air Volume Flow Rate is new reporting variable for AirTerminal:SingleDuct:ConstantVolume:Reheat air terminal object and it is assigning a value for existing variable for AirTerminal:SingleDuct:ConstantVolume:NoReheat air terminal object
Consolidated the update equation in a common new member function for single duct air terminals.
Updated I/O Reference documentation
Diffs is expected in test files with AirTerminal:SingleDuct:ConstantVolume:NoReheat object and this report variable specified.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

Nigusse · 2020-04-29T23:19:18Z

Below is plots of Zone Air Terminal Outdoor Air Volume Flow Rate report variable for AirTerminal:SingleDuct:ConstantVolume:NoReheat air terminal object for develop and this branch. Develop shows zero flow rate because this variable was not assigned a value. This was based on a test file ASHRAE9012016_RestaurantFastFood_Denver.idf. This test file is added as a defect file.

Nigusse · 2020-04-30T17:53:01Z

Added new report variable Zone Air Terminal Outdoor Air Volume Flow Rate for AirTerminal:SingleDuct:ConstantVolume:Reheat object. The plot below shows the OA Vol flow rate for this air terminal.

Nigusse · 2020-05-01T16:25:01Z

The *.rdd and *.Audit output files diffs are caused by addition of new report variable Zone Air Terminal Outdoor Air Volume Flow Rate to AirTerminal:SingleDuct:ConstantVolume:Reheat object.

Nigusse · 2020-05-01T17:53:40Z

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

+\paragraph{Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}}\label{zone-air-terminal-outdoor-air-volume-flow-rate-m3s}
+
+This output is the amount of outdoor air entering the zone. This is the average value over the frequency being reported. The amount of outdoor air is defined as the terminal unit air volume flow rate multiplied by the fraction of outdoor air entering the air loop's outside air system.
+


This is description of the new report variable added for AirTerminal:SingleDuct:ConstantVolume:Reheat air terminal unit.

Nigusse · 2020-05-01T17:54:12Z

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

-\subsubsection{Outputs}
-
-There are no outputs for the constant volume reheat air terminal.
-
 \subsection{AirTerminal:SingleDuct:ConstantVolume:NoReheat}\label{airterminalsingleductconstantvolumenoreheat}


removed since a new report variable listed above is added.

Nigusse · 2020-05-01T17:55:29Z

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

+
+\paragraph{Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}}\label{zone-air-terminal-outdoor-air-volume-flow-rate-m3s}
+
+This output is the amount of outdoor air entering the zone. This is the average value over the frequency being reported. The amount of outdoor air is defined as the terminal unit air volume flow rate multiplied by the fraction of outdoor air entering the air loop's outside air system.



This is missing description of existing report variable for AirTerminal:SingleDuct:ConstantVolume:NoReheat air terminal unit.

Nigusse · 2020-05-01T17:57:44Z

src/EnergyPlus/DualDuct.cc

@@ -1529,7 +1529,6 @@ namespace DualDuct {
        this->dd_airterminalOutlet.AirMassFlowRateMaxAvail = MassFlow;
        this->dd_airterminalOutlet.AirMassFlowRateMinAvail = this->ZoneMinAirFrac * this->dd_airterminalHotAirInlet.AirMassFlowRateMax;
        this->dd_airterminalOutlet.AirEnthalpy = Enthalpy;
-        this->OutdoorAirFlowRate = MassFlow * AirLoopOAFrac;


this is moved to a new common member function CalcOutdoorIAirVolumeFlowRate() added for AirTerminalDualDuct:VAV and AirTerminalDualDuct:ConstantVolume objects.

Nigusse · 2020-05-01T17:58:56Z

src/EnergyPlus/DualDuct.cc

+            // do nothing for now
+        }
+    }
+


the new member common function added for use with AirTerminal:DualDuct:VAV and AirTerminal:DualDuct:ConstantVolume objects.

Will there ever be anything in the ELSE block here?

Nigusse · 2020-05-01T18:00:07Z

src/EnergyPlus/SingleDuct.cc

+                "System",
+                "Average",
+                sd_airterminal(SysNum).SysName);
+


new report variable added for AirTerminal:SingleDuct:ConstantVolume:Reheat object.

Nigusse · 2020-05-01T18:02:35Z

src/EnergyPlus/SingleDuct.cc

@@ -3688,9 +3696,6 @@ namespace SingleDuct {
            }
        }

-        //  set OA report variable
-        this->OutdoorAirFlowRate = (MassFlow / StdRhoAir) * AirLoopOAFrac;
-
        // push the flow rate history


moved to a common new member function added to singleduct air terminal struct.

Nigusse · 2020-05-01T18:03:18Z

src/EnergyPlus/SingleDuct.cc

+            // do nothing for now
+        }
+    }
+


This is the common new member function added to singleduct air terminal struct. This is used for all single air terminal but currently only four of the single duct air terminals have this report variable.

"Same" function in two locations. I'm assuming there's not a parent component. Should there (eventually) be one?

Nigusse · 2020-05-01T18:05:38Z

src/EnergyPlus/SingleDuct.cc

@@ -5310,6 +5315,8 @@ namespace SingleDuct {
        if (Contaminant.GenericContamSimulation) {
            Node(OutletNode).GenContam = Node(InletNode).GenContam;
        }
+        // set OA volume flow rate report variable
+        this->CalcOutdoorAirVolumeFlowRate();


this new member function is called during update() function call as it is used to update a report variable. This function is now invoked during update only improves performance by tiny amount.

Nigusse · 2020-05-01T20:25:50Z

This pull request is ready for review.

mitchute

Pretty straight forward changes here. Assuming CI is happy, this should go in soon.

mitchute · 2020-05-15T14:43:07Z

src/EnergyPlus/DualDuct.cc

+            // do nothing for now
+        }
+    }
+


Will there ever be anything in the ELSE block here?

mitchute · 2020-05-15T14:44:10Z

src/EnergyPlus/SingleDuct.cc

+                "System",
+                "Average",
+                sd_airterminal(SysNum).SysName);
+


mitchute · 2020-05-15T14:47:28Z

src/EnergyPlus/SingleDuct.cc

+            // do nothing for now
+        }
+    }
+


"Same" function in two locations. I'm assuming there's not a parent component. Should there (eventually) be one?

mitchute · 2020-05-15T14:48:11Z

tst/EnergyPlus/unit/AirTerminalSingleDuctConstantVolumeNoReheat.unit.cc

+    // check AT air mass flow rates
+    EXPECT_EQ(expectedMassFlow, thisAirTerminalInlet.AirMassFlowRate);
+    EXPECT_EQ(expectedMassFlow, thisAirTerminalOutlet.AirMassFlowRate);
+    EXPECT_EQ(expected_OAVolFlowRate, thisAirTerminal.OutdoorAirFlowRate);  // OA volume flow rate


mitchute · 2020-05-15T14:48:43Z

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

+  HVAC,Average,Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}
+\end{itemize}
+
+\paragraph{Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}}\label{zone-air-terminal-outdoor-air-volume-flow-rate-m3s}


mitchute · 2020-05-15T14:48:46Z

doc/input-output-reference/src/overview/group-air-distribution-equipment.tex

+  HVAC,Average,Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}
+\end{itemize}
+
+\paragraph{Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}}\label{zone-air-terminal-outdoor-air-volume-flow-rate-m3s}


mitchute · 2020-05-22T16:42:37Z

Looks like this fell off my radar. I'm assuming CI is still happy, so this should be able to merge soon once that has run again with the latest develop pulled in.

Myoldmopar · 2020-05-22T17:55:01Z

These CI results seem pretty reasonable. Added report variable showing AUD and RDD diffs. Github is currently dealing with an incident causing the gh-pages sites to not build, so that's why CI results aren't available (technically they are, and for that branch they are here).

I think I'll go ahead and merge this in once the unit and integration tests finish.

mitchute · 2020-06-02T14:16:26Z

One. More. Time. Seriously, though. It's gonna happen this time.

mitchute · 2020-06-02T19:38:37Z

Some minor updates were needed in the unit tests due to the recent GIO changes. I ran the unit tests and 40-ish files locally, and it all looks good. The minor AUD and RDD diffs are expected, and CI has been consistently good here for a long time. I'm not waiting for CI to run on this again. Merging.

nigusse added 2 commits April 29, 2020 16:09

addressed Zone AT OA volume flow rate reporting issues

e733680

Merge branch 'develop' into 172581983_Issue7950

fbc348a

Nigusse added the Defect Includes code to repair a defect in EnergyPlus label Apr 29, 2020

nigusse added 3 commits April 30, 2020 12:42

Added unit test

f6fbb57

Merge branch 'develop' into 172581983_Issue7950

11676c8

Added new report variable for SingleDuct ConstantVolume Air Terminal

f6ef5bb

Merge branch 'develop' into 172581983_Issue7950

58c4927

removed warning message and cleanup

b11af1f

Nigusse commented May 1, 2020

View reviewed changes

Merge branch 'develop' into 172581983_Issue7950

0fc068f

mitchute reviewed May 15, 2020

View reviewed changes

Myoldmopar and others added 2 commits May 18, 2020 07:49

Merge remote-tracking branch 'origin/develop' into 172581983_Issue7950

3d5652b

Merge branch 'develop' into 172581983_Issue7950

caa380b

Merge branch 'develop' into 172581983_Issue7950

14fd7fe

Merge branch 'develop' into 172581983_Issue7950

6108723

update unit test with GIO changes

6a4e619

mitchute merged commit 6c9ad36 into develop Jun 2, 2020

mitchute deleted the 172581983_Issue7950 branch June 2, 2020 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address zone air terminal zone outdoor air flow rate reporting issues #7955

Address zone air terminal zone outdoor air flow rate reporting issues #7955

Nigusse commented Apr 29, 2020 •

edited

Loading

Nigusse commented Apr 29, 2020

Nigusse commented Apr 30, 2020

Nigusse commented May 1, 2020

Nigusse May 1, 2020

Nigusse May 1, 2020

Nigusse May 1, 2020

Nigusse May 1, 2020

Nigusse May 1, 2020

mitchute May 15, 2020

Nigusse May 1, 2020

mitchute May 15, 2020

Nigusse May 1, 2020

Nigusse May 1, 2020

mitchute May 15, 2020

Nigusse May 1, 2020 •

edited

Loading

Nigusse commented May 1, 2020

mitchute left a comment

mitchute May 15, 2020

mitchute May 15, 2020

mitchute May 15, 2020

mitchute May 15, 2020

mitchute May 15, 2020

mitchute May 15, 2020

mitchute commented May 22, 2020

Myoldmopar commented May 22, 2020 •

edited

Loading

mitchute commented Jun 2, 2020

mitchute commented Jun 2, 2020

		\paragraph{Zone Air Terminal Outdoor Air Volume Flow Rate {[}m3/s{]}}\label{zone-air-terminal-outdoor-air-volume-flow-rate-m3s}

		This output is the amount of outdoor air entering the zone. This is the average value over the frequency being reported. The amount of outdoor air is defined as the terminal unit air volume flow rate multiplied by the fraction of outdoor air entering the air loop's outside air system.

Address zone air terminal zone outdoor air flow rate reporting issues #7955

Address zone air terminal zone outdoor air flow rate reporting issues #7955

Conversation

Nigusse commented Apr 29, 2020 • edited Loading

Pull request overview

Pull Request Author

Reviewer

Nigusse commented Apr 29, 2020

Nigusse commented Apr 30, 2020

Nigusse commented May 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse May 1, 2020 • edited Loading

Choose a reason for hiding this comment

Nigusse commented May 1, 2020

mitchute left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchute commented May 22, 2020

Myoldmopar commented May 22, 2020 • edited Loading

mitchute commented Jun 2, 2020

mitchute commented Jun 2, 2020

Nigusse commented Apr 29, 2020 •

edited

Loading

Nigusse May 1, 2020 •

edited

Loading

Myoldmopar commented May 22, 2020 •

edited

Loading