Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Global Baseboards #7989

Merged
merged 27 commits into from
May 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f016b5c
move boilers data to EnergyPlusData
mitchute May 5, 2020
052d189
steam boilers data to EnergyPlusData
mitchute May 5, 2020
8af176e
absorption chiller data to EnergyPlusData
mitchute May 5, 2020
2ef9854
broken - moving FlowMode enum from boiler to DataPlant
mitchute May 5, 2020
d70b626
Decircularize
Myoldmopar May 6, 2020
7aeb723
Fix unit test flowmode usage
Myoldmopar May 6, 2020
8068254
move condenser type and flow mode chiller options to enum in DataPlant
mitchute May 6, 2020
87c9dcc
ChillerElectricEIR data to EnergyPlusData
mitchute May 6, 2020
d5cceaf
ChillerExhaustAbsorption data to EnergyPlusData
mitchute May 6, 2020
7cbbf21
cleanup boiler naming
mitchute May 6, 2020
a33d108
ChillerGasAbsorption data to EnergyPlusData
mitchute May 6, 2020
c7d7fca
ChillerIndirectAbsorption data to EnergyPlusData
mitchute May 6, 2020
11fc1cc
ChillerReformulatedEIR data to EnergyPlusData
mitchute May 6, 2020
c9335d5
move PlantChiller FlowMode and CondenserType to enums in DataPlant
mitchute May 6, 2020
76bd1c1
Merge branch 'develop' into global_boiler
mitchute May 6, 2020
f2df6db
PlantChillers data to EnergyPlusData
mitchute May 6, 2020
79140ce
Merge branch 'develop' into global_boiler
mitchute May 11, 2020
02ccc64
fixup string literals
mitchute May 11, 2020
1f79305
minor cleanups in baseboard electric before moving data to EnergyPlus…
mitchute May 12, 2020
752d656
Merge branch 'global_boiler' into global_baseboard
mitchute May 12, 2020
32c8484
BaseboardElectric data to EnergyPlusData
mitchute May 12, 2020
2ba808c
cleanup BaseboardRadiator
mitchute May 12, 2020
4478c2a
BaseboardRadiator data to EnergyPlusData
mitchute May 13, 2020
e501e43
minor cleanups
mitchute May 13, 2020
b6dab27
Merge branch 'develop' into global_boiler
mitchute May 13, 2020
b9dfdee
cleanup pointer, cleanup references, minor renaming
mitchute May 13, 2020
5d056ea
Merge branch 'global_boiler' into global_baseboard
mitchute May 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
378 changes: 107 additions & 271 deletions src/EnergyPlus/BaseboardElectric.cc

Large diffs are not rendered by default.

51 changes: 13 additions & 38 deletions src/EnergyPlus/BaseboardElectric.hh
Original file line number Diff line number Diff line change
Expand Up @@ -57,28 +57,12 @@

namespace EnergyPlus {

// Forward declarations
struct EnergyPlusData;
struct BaseboardElectricData;

namespace BaseboardElectric {

// Using/Aliasing

// Data
// MODULE PARAMETER DEFINITIONS
extern std::string const cCMO_BBRadiator_Electric;
extern Real64 const SimpConvAirFlowSpeed; // m/s

// DERIVED TYPE DEFINITIONS

// MODULE VARIABLE DECLARATIONS:
extern int NumBaseboards;
extern Array1D_bool MySizeFlag;
extern Array1D_bool CheckEquipName;

// SUBROUTINE SPECIFICATIONS FOR MODULE BaseboardRadiator

// Types

struct BaseboardParams
{
// Members
Expand All @@ -95,15 +79,18 @@ namespace BaseboardElectric {
Real64 Energy;
Real64 ElecUseLoad;
Real64 ElecUseRate;
int ZonePtr; // point to teh zone where the basebaord is located
int ZonePtr; // point to the zone where the basebaord is located
int HeatingCapMethod; // - Method for heating capacity scaledsizing calculation- (HeatingDesignCapacity, CapacityPerFloorArea,
// FracOfAutosizedHeatingCapacity)
Real64 ScaledHeatingCapacity; // - scaled maximum heating capacity {W} or scalable variable of zone HVAC equipment, {-}, or {W/m2}
bool MySizeFlag;
bool CheckEquipName;

// Default Constructor
BaseboardParams()
: SchedPtr(0), NominalCapacity(0.0), BaseboardEfficiency(0.0), AirInletTemp(0.0), AirInletHumRat(0.0), AirOutletTemp(0.0), Power(0.0),
Energy(0.0), ElecUseLoad(0.0), ElecUseRate(0.0), ZonePtr(0), HeatingCapMethod(0.0), ScaledHeatingCapacity(0.0)
Energy(0.0), ElecUseLoad(0.0), ElecUseRate(0.0), ZonePtr(0), HeatingCapMethod(0.0), ScaledHeatingCapacity(0.0), MySizeFlag(true),
CheckEquipName(true)
{
}
};
Expand All @@ -114,30 +101,18 @@ namespace BaseboardElectric {
Array1D_string FieldNames;

// Default Constructor
BaseboardNumericFieldData()
{
}
BaseboardNumericFieldData() = default;
};

// Object Data
extern Array1D<BaseboardParams> Baseboard;
extern Array1D<BaseboardNumericFieldData> BaseboardNumericFields;

// Functions

void clear_state();

void SimElectricBaseboard(EnergyPlus::EnergyPlusData &state, std::string const &EquipName, int const ActualZoneNum, int const ControlledZoneNum, Real64 &PowerMet, int &CompIndex);

void GetBaseboardInput();
void SimElectricBaseboard(EnergyPlusData &state, std::string const &EquipName, int ActualZoneNum, int ControlledZoneNum, Real64 &PowerMet, int &CompIndex);

void InitBaseboard(EnergyPlus::EnergyPlusData &state, int const BaseboardNum, int const ControlledZoneNum);
void GetBaseboardInput(BaseboardElectricData &baseboard);

void SizeElectricBaseboard(EnergyPlus::EnergyPlusData &state, int const BaseboardNum);
void InitBaseboard(EnergyPlusData &state, BaseboardElectricData &baseboard, int BaseboardNum, int ControlledZoneNum);

void SimElectricConvective(int const BaseboardNum, Real64 const LoadMet);
void SizeElectricBaseboard(EnergyPlusData &state, BaseboardElectricData &baseboard, int BaseboardNum);

void ReportBaseboard(int const BaseboardNum);
void SimElectricConvective(BaseboardElectricData &baseboard, int BaseboardNum, Real64 LoadMet);

} // namespace BaseboardElectric

Expand Down
Loading