Provide accurate value of RatedInletAirHumRat in DXCoils #7993
Conversation
|
@lgu1234 you had more to do on this after the discussion on the sizing call, right? |
|
@Myoldmopar Yes. I will do little bit more tomorrow. |
|
@Myoldmopar It is ready for review. |
| Real64 RatedInletWetBulbTemp = 19.44; // 19.44 or 67F | ||
| Real64 RatedInletAirHumRat = 0.01125; // Humidity ratio corresponding to 80F dry bulb/67F wet bulb | ||
| Real64 RatedInletWetBulbTemp = 19.4444; // 19.44 or 67F | ||
| Real64 RatedInletAirHumRat = 0.0111847; // Humidity ratio corresponding to 80F dry bulb/67F wet bulb |
There was a problem hiding this comment.
I wish these could be declared on some single location, but regardless these seem completely valid.
| EXPECT_NEAR(0.788472, DXCoil(1).RatedSHR(1), 0.0000001); | ||
| EXPECT_NEAR(0.0003944, CBF_calculated, 0.0000001); | ||
| EXPECT_NEAR(0.792472, DXCoil(1).RatedSHR(1), 0.0000001); | ||
| EXPECT_NEAR(0.00213735, CBF_calculated, 0.0000001); |
There was a problem hiding this comment.
That small change on SHR caused a pretty big difference in the bypass factor. I don't disagree, just noting.
| Real64 Twet = 19.4444; | ||
| Real64 RatedW = Psychrometrics::PsyWFnTdbTwbPb(Tdb, Twet, 101325.0); | ||
| EXPECT_NEAR(RatedInletAirHumRat, RatedW, 0.000001); | ||
| } |
There was a problem hiding this comment.
This is kind of a funny little unit test. Where is RatedInletAirHumRat declared?
There was a problem hiding this comment.
@Myoldmopar The RatedInletAirHumRat is defined at line 159 in DXCoils as below:
Real64 const RatedInletAirHumRat(0.0111847); // Humidity ratio corresponding to 80F dry bulb/67F wet bulb
|
@lgu1234 the code changes seem fine. This needs a new set of CI results, and there are some conflicts. I'll take care of them shortly and let CI respond and then I'll take another look. |
|
OK, I pulled, merged and resolved conflicts, built, and tested locally. All is well. If CI approves I think this is ready. |
|
OK, I think it's time to pull the trigger on this one. I think CI might be all done catching up from the busy workweek so this shouldn't start throwing diffs as long as other branches get develop pulled in. Thanks @lgu1234 |
Pull request overview
Two changes were made in DXCoils. The first change is to add two more digits for wet bulb temperature at 19.4444, so that Twet is more accurate than 19.44 and has equivalent accuracy to the rated dry bulb temperature at 26.6667. The second change is to calculate rated inlet air W using rated dry bulb temperature at 26.6667, rate wet bulb temperature at 19.4444, and standard see level pressure at 101325. The value used after round off is 0.0111847.
Real64 const RatedInletWetBulbTemp(19.4444); // 19.44 or 67F
Real64 const RatedInletAirHumRat(0.0111847); // Humidity ratio corresponding to 80F dry bulb/67F wet bulb
At the same time, some unit test files are revised due to the above changes.
The present changes are limited in DXCoils. If the changes are accepted, more changes are expected in both Coil:Cooling:DX and VariableSpeedCoil, because both coils also use RatedInletAirHumRat.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.