Fix HeatPump:PlantLoop:EIR:* Inlet Temperatures

[mitchute]

Fixes #8071

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mitchute]

From the test file provided by the user for an air-source heat pump.

The unit never operated so the temperatures were never updated.

After the fix, the temperatures now behave as they should.

[Myoldmopar]

I know this is draft, but this looks like a reasonable fix to me.

[Myoldmopar]

As for the failing unit test, I wouldn't be surprised if the new value is simply the correct value.

[Myoldmopar]

OK, I understand why that unit test was failing. Previously the unit test was setting the inlet node conditions to specified values so that the unit would run under those conditions. This worked because inside doPhysics is where we were pulling the data from the node onto the unit data structure. However, your change here pulled that assignment up to the simulate level, so the unit was running with zero inlet temperatures on both source and load side. To fix it, I just changed the unit test so that it sets up the data structure inlet temps directly and runs the physics calculation. Everything seems good now, so I'll let CI run and this should be able to drop in shortly.

[Myoldmopar]

All good here, merging. Thanks @mitchute !