Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Global zone temp predictor corrector #8092

Merged
merged 17 commits into from
Jun 24, 2020

Conversation

brianlball
Copy link
Contributor

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)
  • DESCRIBE PURPOSE OF THIS PULL REQUEST

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@brianlball brianlball added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Jun 18, 2020
@brianlball brianlball added this to the EnergyPlus 9.4.0 milestone Jun 18, 2020
@brianlball brianlball requested a review from Myoldmopar June 18, 2020 22:29
@Myoldmopar
Copy link
Member

I resolved the conflicts in this branch and built and ran locally. Everything looks fine, but I'll still give CI a little time to at least spot check my changes before merging.

@Myoldmopar
Copy link
Member

Something went awry with the Ubuntu C image, the debug unit test build is never faster than the release test one. I'll check on it.

@Myoldmopar
Copy link
Member

Or...maybe not...OK, carry on.

@Myoldmopar
Copy link
Member

Alright, I'm going to move forward without waiting on Windows. If something was wrong here, it would almost certainly be revealed in the Linux build/tests. Merging this in and moving on.

@Myoldmopar Myoldmopar merged commit e2c0904 into develop Jun 24, 2020
@Myoldmopar Myoldmopar deleted the global_zone_temp_predictor_corrector branch June 24, 2020 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants