Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes AirTerminal Mixer used with FanCoilUnit does not respond to fan availability schedule #8115

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Fixes AirTerminal Mixer used with FanCoilUnit does not respond to fan availability schedule #8115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de2fbb2
Fixed issue 8107 and added unit test
Jun 25, 2020
e0473d9
Merge branch 'develop' into 173517788_Issue8107
Jun 26, 2020
8f300ba
Format change and cleanup
Jun 26, 2020
963a71f
Merge develop and cleanup
Jun 28, 2020
8dfc901
Merge branch 'develop' into 173517788_Issue8107
Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/EnergyPlus/FanCoilUnits.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,12 @@ namespace FanCoilUnits {
} else {
if (!UtilityRoutines::SameString(FanCoil(FanCoilNum).FanType, "Fan:SystemModel")) {
GetFanType(state.fans, FanCoil(FanCoilNum).FanName, FanCoil(FanCoilNum).FanType_Num, errFlag, CurrentModuleObject, FanCoil(FanCoilNum).Name);
FanCoil(FanCoilNum).fanAvailSchIndex = Fans::GetFanAvailSchPtr(state.fans, FanCoil(FanCoilNum).FanType, FanCoil(FanCoilNum).FanName, errFlag);
if (errFlag) {
ShowContinueError("Occurs in " + CurrentModuleObject + " = " + FanCoil(FanCoilNum).Name);
ErrorsFound = true;
errFlag = false;
}
{
auto const SELECT_CASE_var(FanCoil(FanCoilNum).FanType_Num);
if ((SELECT_CASE_var == FanType_SimpleConstVolume) || (SELECT_CASE_var == FanType_SimpleVAV) ||
Expand Down Expand Up @@ -711,6 +717,7 @@ namespace FanCoilUnits {
FanCoil(FanCoilNum).FanType_Num = DataHVACGlobals::FanType_SystemModelObject;
HVACFan::fanObjs.emplace_back(new HVACFan::FanSystem(FanCoil(FanCoilNum).FanName)); // call constructor
FanCoil(FanCoilNum).FanIndex = HVACFan::getFanObjectVectorIndex(FanCoil(FanCoilNum).FanName); // zero-based
FanCoil(FanCoilNum).fanAvailSchIndex = HVACFan::fanObjs[FanCoil(FanCoilNum).FanIndex]->availSchedIndex;
FanCoil(FanCoilNum).FanAirVolFlow = HVACFan::fanObjs[FanCoil(FanCoilNum).FanIndex]->designAirVolFlowRate;
// Check that the fan volumetric flow rate is greater than or equal to the FCU volumetric flow rate
if (FanCoil(FanCoilNum).MaxAirVolFlow > FanCoil(FanCoilNum).FanAirVolFlow && FanCoil(FanCoilNum).FanAirVolFlow != AutoSize) {
Expand Down Expand Up @@ -1308,7 +1315,8 @@ namespace FanCoilUnits {
}
}
// Set the inlet node mass flow rate
if ((GetCurrentScheduleValue(FanCoil(FanCoilNum).SchedPtr) > 0.0 || DataHVACGlobals::ZoneCompTurnFansOn) &&
if (((GetCurrentScheduleValue(FanCoil(FanCoilNum).SchedPtr) > 0.0 && GetCurrentScheduleValue(FanCoil(FanCoilNum).fanAvailSchIndex) > 0.0) ||
DataHVACGlobals::ZoneCompTurnFansOn) &&
!DataHVACGlobals::ZoneCompTurnFansOff) {
Node(InletNode).MassFlowRate = FanCoil(FanCoilNum).MaxAirMassFlow;
Node(InletNode).MassFlowRateMaxAvail = Node(InletNode).MassFlowRate;
Expand Down Expand Up @@ -3538,7 +3546,8 @@ namespace FanCoilUnits {

// Assume the unit is able to vary the flow. A cycling unit is treated as
// if it were variable flow, with the flow being the averaqe flow over the time step
if ((GetCurrentScheduleValue(FanCoil(FanCoilNum).SchedPtr) > 0.0 || DataHVACGlobals::ZoneCompTurnFansOn) &&
if (((GetCurrentScheduleValue(FanCoil(FanCoilNum).SchedPtr) > 0.0 && GetCurrentScheduleValue(FanCoil(FanCoilNum).fanAvailSchIndex) > 0.0) ||
DataHVACGlobals::ZoneCompTurnFansOn) &&
!DataHVACGlobals::ZoneCompTurnFansOff) {
if (FanCoil(FanCoilNum).CapCtrlMeth_Num != CCM_ConsFanVarFlow) {
if (FanCoil(FanCoilNum).CapCtrlMeth_Num != CCM_ASHRAE) Node(InletNode).MassFlowRate = PartLoad * Node(InletNode).MassFlowRateMax;
Expand Down
3 changes: 2 additions & 1 deletion src/EnergyPlus/FanCoilUnits.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ namespace FanCoilUnits {
Real64 DesZoneHeatingLoad; // used for reporting in watts
int DSOAPtr; // design specification outdoor air object index
bool FirstPass; // detects first time through for resetting sizing data
int fanAvailSchIndex; // fan availability schedule index

// SZVAV Model inputs
std::string Name; // name of unit
Expand Down Expand Up @@ -269,7 +270,7 @@ namespace FanCoilUnits {
QUnitOutNoHC(0.0), QUnitOutMaxH(0.0), QUnitOutMaxC(0.0), LimitErrCountH(0), LimitErrCountC(0), ConvgErrCountH(0), ConvgErrCountC(0),
HeatPower(0.0), HeatEnergy(0.0), TotCoolPower(0.0), TotCoolEnergy(0.0), SensCoolPower(0.0), SensCoolEnergy(0.0), ElecPower(0.0),
ElecEnergy(0.0), DesCoolingLoad(0.0), DesHeatingLoad(0.0), DesZoneCoolingLoad(0.0), DesZoneHeatingLoad(0.0), DSOAPtr(0),
FirstPass(true), MaxCoolCoilFluidFlow(0.0), MaxHeatCoilFluidFlow(0.0), DesignMinOutletTemp(0.0), DesignMaxOutletTemp(0.0),
FirstPass(true), fanAvailSchIndex(0), MaxCoolCoilFluidFlow(0.0), MaxHeatCoilFluidFlow(0.0), DesignMinOutletTemp(0.0), DesignMaxOutletTemp(0.0),
MaxNoCoolHeatAirMassFlow(0.0), MaxCoolAirMassFlow(0.0), MaxHeatAirMassFlow(0.0), LowSpeedCoolFanRatio(0.0), LowSpeedHeatFanRatio(0.0),
CoolCoilFluidInletNode(0), CoolCoilFluidOutletNodeNum(0), HeatCoilFluidInletNode(0), HeatCoilFluidOutletNodeNum(0), CoolCoilLoopNum(0),
CoolCoilLoopSide(0), CoolCoilBranchNum(0), CoolCoilCompNum(0), HeatCoilLoopNum(0), HeatCoilLoopSide(0), HeatCoilBranchNum(0),
Expand Down
Loading