Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed SingleDuctAirTerminal Heat/Cool Rate/Energy variables #8168

Merged
merged 6 commits into from
Jul 22, 2020

Conversation

Nigusse
Copy link
Contributor

@Nigusse Nigusse commented Jul 20, 2020

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Nigusse Nigusse added the Defect Includes code to repair a defect in EnergyPlus label Jul 20, 2020
@Nigusse
Copy link
Contributor Author

Nigusse commented Jul 20, 2020

@mjwitte I removed the member variables, associated calculations and modified unit tests. Run unit tests locally and all passed.

@mjwitte mjwitte added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring and removed Defect Includes code to repair a defect in EnergyPlus labels Jul 21, 2020
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nigusse Looks good, except now there's an unused variable warning on the unit test. Once that's cleaned up, this can drop in.

@mjwitte mjwitte merged commit 175ff74 into develop Jul 22, 2020
@mjwitte mjwitte deleted the 173906228_Issue8161 branch July 22, 2020 13:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SingleDuctAirTerminal Heat/Cool Rate/Energy variables are no longer used
6 participants