Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Penumbra dependency to clean up warnings #8205

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

nealkruis
Copy link
Member

Pull request overview

Updates GLFW to v3.3.2.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)

@nealkruis nealkruis added Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Aug 13, 2020
@nealkruis nealkruis added this to the EnergyPlus 9.4.0 milestone Aug 13, 2020
@nealkruis nealkruis requested a review from Myoldmopar August 13, 2020 20:54
@nealkruis nealkruis self-assigned this Aug 13, 2020
@Myoldmopar
Copy link
Member

Indeed that got rid of the warning. It's too bad that the spurious CI failure ruined what could have been a fully green set, but oh well. I'm going to merge this, thanks @nealkruis

@Myoldmopar Myoldmopar merged commit fa7b742 into NREL:develop Aug 14, 2020
@nealkruis nealkruis deleted the fix-glfw-warning branch August 14, 2020 15:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog NotIDDChange Code does not impact IDD (can be merged after IO freeze)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLFW Build Warning on Mac 10.15
6 participants