We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
@eringold reported a model where E+ throws (can you post it here maybe?). He's got two spaces, each with a daylight control with phiRotation = 0.0.
After combine spaces he ends up with a very very tiny value, but one that is negative: -3.1805546814635199E-15
-3.1805546814635199E-15
I tracked it down to #3858
primaryDaylightingControl->phiRotationAroundZAxis() may have the wrong sign
primaryDaylightingControl->phiRotationAroundZAxis()
See #3858 (comment)
Current:
OpenStudio/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp
Line 466 in 057a86b
Prior to #3858,
OpenStudio/openstudiocore/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp
Line 478 in 58ed43d
While I think the wrong angle was used and the radToDeg apparently shouldn't be used, the - sign may be needed.
Some additional details about your environment for this issue (if relevant):
The text was updated successfully, but these errors were encountered:
Fix #4448 - DaylightingControl rotationa round Y axis uses opposite r…
3dbf3d4
…otation direction in OS v E+
Merge pull request #4452 from NREL/4448_phiRotation_DaylightControl
6265b7e
Fix #4448 - Issues with angles in DaylightingControl
jmarrec
Successfully merging a pull request may close this issue.
Issue overview
@eringold reported a model where E+ throws (can you post it here maybe?).
He's got two spaces, each with a daylight control with phiRotation = 0.0.
After combine spaces he ends up with a very very tiny value, but one that is negative:
-3.1805546814635199E-15
I tracked it down to #3858
primaryDaylightingControl->phiRotationAroundZAxis()
may have the wrong signSee #3858 (comment)
Current:
OpenStudio/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp
Line 466 in 057a86b
Prior to #3858,
OpenStudio/openstudiocore/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp
Line 478 in 58ed43d
While I think the wrong angle was used and the radToDeg apparently shouldn't be used, the - sign may be needed.
Current Behavior
Expected Behavior
Steps to Reproduce
Possible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
The text was updated successfully, but these errors were encountered: