Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

primaryDaylightingControl->phiRotationAroundZAxis() may have wrong sign #4448

Closed
jmarrec opened this issue Sep 29, 2021 · 0 comments · Fixed by #4452
Closed

primaryDaylightingControl->phiRotationAroundZAxis() may have wrong sign #4448

jmarrec opened this issue Sep 29, 2021 · 0 comments · Fixed by #4452

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 29, 2021

Issue overview

@eringold reported a model where E+ throws (can you post it here maybe?).
He's got two spaces, each with a daylight control with phiRotation = 0.0.

After combine spaces he ends up with a very very tiny value, but one that is negative: -3.1805546814635199E-15

I tracked it down to #3858

primaryDaylightingControl->phiRotationAroundZAxis() may have the wrong sign

See #3858 (comment)

Current:

double glareAngle = primaryDaylightingControl->phiRotationAroundZAxis();

Prior to #3858,

double glareAngle = -openstudio::radToDeg(primaryDaylightingControl->thetaRotationAroundYAxis());

While I think the wrong angle was used and the radToDeg apparently shouldn't be used, the - sign may be needed.

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

@jmarrec jmarrec added component - IDF Translation Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Sep 29, 2021
jmarrec added a commit that referenced this issue Sep 30, 2021
@tijcolem tijcolem removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Oct 5, 2021
@tijcolem tijcolem added this to the OpenStudio SDK 3.3.0 milestone Oct 5, 2021
tijcolem added a commit that referenced this issue Oct 6, 2021
Fix #4448 - Issues with angles in DaylightingControl
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants