-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Addresses #2958, add ZoneHVAC:CoolingPanel:RadiantConvective:Water to OpenStudio #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
CI Results for 0da0a8c:
|
jmarrec
added a commit
that referenced
this pull request
Feb 3, 2021
joseph-robertson
added a commit
that referenced
this pull request
Feb 4, 2021
Hotfix: Add missing \ip-units following #4157
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
component - Model
Enhancement Request
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
ZoneHVACBaseboardRadiantConvectiveWater
andCoilHeatingWaterBaseboardRadiant
, except that we now haveZoneHVACCoolingPanelRadiantConvectiveWater
andCoilCoolingWaterPanelRadiant
Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)src/openstudio_lib/library/OpenStudioPolicy.xml
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.