Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes bug in SurfaceProperty:ExposedFoundationPerimeter IDD #4179

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

macumber
Copy link
Contributor

@macumber macumber commented Jan 8, 2021

Pull request overview

In support of rd2's TDB measure for thermally derating envelope and automatically generating Kiva foundation inputs https://github.com/rd2/tbd/releases/tag/v1.1.0

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • OpenStudio IDD changes

Labels:

  • If change to an IDD file, add the label IDDChange - I cannot apply labels
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@tijcolem tijcolem added this to the OpenStudio SDK 3.2.0 milestone Jan 8, 2021
@tijcolem tijcolem merged commit 71710b6 into NREL:develop Jan 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in SurfaceProperty:ExposedFoundationPerimeter IDD
2 participants