Addresses #4182, provide OS SDK/API support for the EnergyPlus "Generator:WindTurbine" object

[joseph-robertson]

Pull request overview

• Fixes Provide OS SDK/API support for the EnergyPlus "Generator:WindTurbine" object  #4182
• Also add RT
• Questions:
  • Which, if any, of the following 7 should be passed into the ctor (or should they get values from the docs, which is what this PR current does)?
    • Rated Rotor Speed
    • Rotor Diameter
    • Overall Height
    • Rated Power
    • Rated Wind Speed
    • Cut In Wind Speed
    • Cut Out Wind Speed

Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

@joseph-robertson I left some comments, and some - I think - required changes (making one field required for eg, removing the creation of the ECLD in the Ctor too). Address what you think makes sense, just mark comments resolved for what doesn't (I left everything so you see them, even those where I was wrong such as availability schedule). There should be very minimal changes before this can drop in as it's 95% there!

To answer the question in the OP:

Which, if any, of the following 7 should be passed into the ctor (or should they get values from the docs, which is what this PR current does)

I think your current implemenation is fine.

[jmarrec]

Tested that OS-res test in NREL/OpenStudio-resources#128 is still passing. This can merge and NREL/OpenStudio-resources#128 as well, good job @joseph-robertson !

[ci-commercialbuildings]

CI Results for 450951f:

• Linux:

  • OpenStudio-3.1.1-alpha+04a3996dc8-Linux.deb
  • OpenStudio-3.1.1-alpha+04a3996dc8-Linux.tar.gz

• Darwin:

  • OpenStudio-3.1.1-alpha+80c3697b48-Darwin.dmg
  • OpenStudio-3.1.1-alpha+80c3697b48-Darwin.tar.gz

• Windows: