Update to Ruby 2.7.2 #4207
Update to Ruby 2.7.2 #4207
Conversation
|
Here the CI results for the full build on Jenkins: And results running regression ruby-2.7.2 vs The ruby test bundle_git need to update but those are the only unit tests that are currently failing (minus the filtered ones). |
|
not sure what's going with the python bindings. Perhaps something broke related to the ruby change. |
| # This isn't ideal but there really is no available method to add specs for our use case. | ||
| # Using self.dirs=() works for ruby official gems but since it appends the dir paths with 'specifications' it breaks for bundled gem specs | ||
| def self.add_spec spec | ||
| warn "Gem::Specification.add_spec is deprecated and will be removed in RubyGems 3.0" unless Gem::Deprecate.skip |
There was a problem hiding this comment.
This is not ideal but not sure what do here since this method is now remove in rubygems > 3.0.
I think it's easy this or patching ruby source.
|
last commits should resolve the bundle git failures. |
|
@jmarrec I think we are over the limit of pypi... says we are over the 10GB limit. |
|
@tijcolem have you or can you attempt to trigger a nuget package build? I want to double check that it still works so there are no surprises at release time. |
|
@kbenne Here's a link to the nuget 32/64 bit package. https://openstudio-ci-builds.s3-us-west-2.amazonaws.com/ruby_272/OpenStudio.3.1.1-alpha.nupkg @brianlball I'll try and free up some space. |
|
@brianlball @jmarrec I free'd up a bunch of space on test.pypi.org. We'll have to implement a scrubber of some form as the limits of 10GB get filled fairly quickly. We had about 60 python packages. |
|
I'm going to go ahead and merge, but in testing this I uncovered the following issue that should be addressed. I'm pretty sure it is unrelated to this ruby change. |
I noticed that. As owner, I got one email per package deleted :) |
Update ruby from 2.5.5 to 2.7.2 and include test package of openstudio-gems.
resolves #4134 (see checklist of items).
Outstanding issues:
The above two can be done separately as they are released.
Before merging we should merge outstanding PRs that are ready as this will require CI changes going forward. CI will need to have 2.7.2 to run ruby tests.
Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.