Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix #4240 (and more): add missing \ip-units gal/min via a script #4243

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Fix #4240 (and more): add missing \ip-units gal/min via a script #4243

merged 3 commits into from
Mar 19, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 12, 2021

Pull request overview

Fix #4240 (and more): add missing \ip-units gal/min via a script

Perhaps we should call the script on one of the CI runners @tijcolem ?

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Mar 12, 2021
@jmarrec jmarrec requested a review from tijcolem March 12, 2021 09:17
@jmarrec jmarrec self-assigned this Mar 12, 2021
jmarrec
jmarrec commented Mar 12, 2021
View reviewed changes
developer/ruby/FindAndAddMissingIPUnits.rb

optparse = OptionParser.new do |opts|

opts.on("-f", "--[no-]fix", "Add the missing ipUnits to the OpenSutdio.idd (note: LOTS of whitespace changes...)") do |fix|
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require running the "iddWrapper.save" once to do the whitespace changes once. I don't think it's really worth it here...

resources/model/OpenStudio.idd
@@ -11810,6 +11814,7 @@ OS:AirTerminal:SingleDuct:ConstantVolume:CooledBeam,
N2, \field Maximum Total Chilled Water Volumetric Flow Rate
\type real
\units m3/s
\ip-units gal/min
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual specific fix for #4240

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Mar 12, 2021 •
edited
Loading

CI Results for 466e992:

@tijcolem
Copy link
Collaborator

Windows looks good after rebuild. This is good to drop in

@tijcolem tijcolem merged commit 4dc935b into develop Mar 19, 2021
@tijcolem tijcolem deleted the 4240_ipUnits branch March 19, 2021 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tijcolem tijcolem tijcolem approved these changes

Assignees

@jmarrec jmarrec

Labels
component - Model IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong IP unit for Cooled Beam air terminal 'maximum total chilled water volumetric flow rate'
3 participants
@jmarrec @ci-commercialbuildings @tijcolem