Ruby 2 7 io method

[tijcolem]

Fix #4301

This resolves the issue as outline in #4301. This will need to happen once we upgrade to ruby 3.0 so it's proably better we get this in sooner than trying to silence them. As of now, ruby 2.7.2 that in used in the cli just outputs a deprecation warning (although this is annoying and verbose) and our original code works fine.

Here was a simple test that demonstrates the new usage.

FILE WRITES USING MIXED ARGS and KEYWORDS

f = File.open("log1.txt", "w" )
f.write("Go Avs")
f.close()

f = File.open("log2.txt", "w" )
f.write("Go Blackhwaks")
f.close()

f = File.open("log3.txt", mode: 'wb:UTF-16LE')
f.write("Go Bruins")
f.close()

f = File.open("log4.txt", 'w', encoding: 'iso-8859-1')
f.write("Go Blues")
f.close()

f = File.open("log5.txt", "w", cr_newline: true )
f.write("Go Wild")
f.close()

f = File.open("log6.txt",'w:iso-8859-1', cr_newline: true )
f.write("Go Leafs")
f.close()

FILE READS USING MIXED ARGS and KEYWORDS

f = File.open("log1.txt", "r" )
puts f.readlines
f.close()

f = File.open("log2.txt", "r" )
puts f.readlines
f.close()

f = File.open("log3.txt", mode: 'rb:UTF-16LE')
puts f.readlines
f.close()

f = File.open("log4.txt", 'r', encoding: 'iso-8859-1')
puts f.readlines
f.close()

f = File.open("log5.txt", "r", cr_newline: true )
puts f.readlines
f.close()

f = File.open("log6.txt",'r:iso-8859-1', cr_newline: true )
puts f.readlines
f.close()

OBSERVED OUTPUTS

WRITES

self.open(name, *args), name = /dev/null, args = ["w"], options = {}
self.open(name, *args), name = log1.txt, args = ["w"], options = {}
self.open(name, *args), name = log2.txt, args = ["w"], options = {}
self.open(name, *args), name = log3.txt, args = [], options = {:mode=>"wb:UTF-16LE"}
self.open(name, *args), name = log4.txt, args = ["w"], options = {:encoding=>"iso-8859-1"}
self.open(name, *args), name = log5.txt, args = ["w"], options = {:cr_newline=>true}
self.open(name, *args), name = log6.txt, args = ["w:iso-8859-1"], options = {:cr_newline=>true}

READS

self.open(name, *args), name = log1.txt, args = ["r"], options = {}
Go Avs
self.open(name, *args), name = log2.txt, args = ["r"], options = {}
Go Blackhwaks
self.open(name, *args), name = log3.txt, args = [], options = {:mode=>"rb:UTF-16LE"}
Go Bruins
self.open(name, *args), name = log4.txt, args = ["r"], options = {:encoding=>"iso-8859-1"}
Go Blues
self.open(name, *args), name = log5.txt, args = ["r"], options = {:cr_newline=>true}
Go Wild
self.open(name, *args), name = log6.txt, args = ["r:iso-8859-1"], options = {:cr_newline=>true}
Go Leafs

[shorowit]

Thank you @tijcolem!

[jmarrec]

looks good to me.

[jmarrec]

cppcheck failure has nothing to do with this PR:

[src/utilities/geometry/Intersection.cpp:92]:(warning),[constStatement],Found suspicious operator '>'

[ci-commercialbuildings]

CI Results for dcde15e:

• Ubuntu 18.04:

  • OpenStudio-3.2.0-alpha+dcde15efba-Ubuntu-18.04.deb
  • OpenStudio-3.2.0-alpha+dcde15efba-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.2.0-alpha+dcde15efba-Ubuntu-20.04.deb
  • OpenStudio-3.2.0-alpha+dcde15efba-Ubuntu-20.04.tar.gz

• Darwin:

  • OpenStudio-3.2.0-alpha+dcde15efba-Darwin.dmg
  • OpenStudio-3.2.0-alpha+dcde15efba-Darwin.tar.gz

• Windows:

  • OpenStudio-3.2.0-alpha+dcde15efba-Windows.exe
  • OpenStudio-3.2.0-alpha+dcde15efba-Windows.tar.gz