Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolves #4395 Add in CLI option to use epJSON #4418

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

tijcolem
Copy link
Collaborator

Pull request overview

This adds in a cli option --epjson to pass into the workflow gem to use epJSON vs IDF.

See NREL/OpenStudio-workflow-gem#136 for all the details on usage in workflow gem.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@tijcolem tijcolem marked this pull request as draft August 25, 2021 18:01
@tijcolem
Copy link
Collaborator Author

Converted to draft as need to add test cases and file an issue related IDF-epJSON conversion format.

@tijcolem tijcolem marked this pull request as ready for review September 7, 2021 19:33
@tijcolem tijcolem requested a review from kbenne September 7, 2021 19:34
@tijcolem tijcolem self-assigned this Sep 7, 2021
@tijcolem tijcolem added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Sep 7, 2021
@kbenne
Copy link
Contributor

kbenne commented Sep 20, 2021

This seems like all we need on the cli side. Awesome!

@tijcolem
Copy link
Collaborator Author

@kbenne Cool. Now that NREL/OpenStudio-workflow-gem#136 is merged I will drop this one in as well.

@tijcolem tijcolem merged commit 05c754a into develop Sep 20, 2021
@tijcolem tijcolem deleted the issue_4395 branch September 20, 2021 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component - CLI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to export epJSON
3 participants