Issue 4361

[ggartside]

Pull request overview

• Fixes OpenStudio API-reported surface "netArea" (when dealing with Frame & Divider objects) #4361

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[tijcolem]

@ggartside Can you remove those .patch files? I don't think you want to include these @macumber mentioned.

[ggartside]

I think you already removed the patches?

[tijcolem]

@ggartside Yep, I just pushed up a commit to remove those.

[jmarrec]

@ggartside I left some review comments. Most of it is just syntax/nitpicking, but I did leave three marked * [ ] TODO: that need attention (some are questions, and I would be satisfied if the answer is just "No, it is intended")

[jmarrec]

• TODO: Is the break intended? I don't understand everything that's going on, but don't you want to fix all of them?
  Also, why not make this check directly in the loop above when populating roughOpenins?

[ggartside]

Yes you are correct an original iteration had a loop that checked each vertex and the break was to hop out of that loop - good find! I also found I'd re-used the name vertices in the second loop and had missed a place where I needed to get the inverse of the transform

I probably could have combined the first two loops, but I think separating them makes the code easier to follow

1. First loop sets up the sub surface rough opening vertices in the coordinate space of the parent surface
2. Second loop checks these vertices to see if they extend outside the parent surface
3. Third loop checks each subsurface for overlaps with adjacent sub surfaces

[jmarrec]

I applied my nitpicking changes and moved the tests to ModelFixture. I resolved all outdated review comments as a result. You have 4 reviews TODO left in the review above.

[tijcolem]

@ggartside Just following up on this PR. Have you addressed the TODO @jmarrec requested? Let's do another review and then we can hopefully get this merged in.

[ci-commercialbuildings]

CI Results for 155a734:

• Ubuntu 18.04:

  • OpenStudio-3.3.1-alpha+f94a26bb1b-Ubuntu-18.04.deb
  • OpenStudio-3.3.1-alpha+f94a26bb1b-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.3.1-alpha+24e3899831-Ubuntu-20.04.deb
  • OpenStudio-3.3.1-alpha+24e3899831-Ubuntu-20.04.tar.gz

• Darwin:

  • OpenStudio-3.3.1-alpha+64f00e6461-Darwin.dmg
  • OpenStudio-3.3.1-alpha+64f00e6461-Darwin.tar.gz

• Windows:

  • OpenStudio-3.3.1-alpha+af6090ddb0-Windows.exe
  • OpenStudio-3.3.1-alpha+af6090ddb0-Windows.tar.gz

• Code Coverage:

  • OpenStudio-155a734b538c6c47ab179fda986147d9a71f1f29.gcov.html

[tijcolem]

Looks like the review comments have been addressed on this so I'm going to merge.