Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better string representation of Matrix and Transformation in the bindings #4474

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Oct 19, 2021

Pull request overview

Did that during interactive debugging for the Space PR, so upstreaming the changes

Before:

[1] OpenStudio(main)> m = OpenStudio::Matrix.new(4, 4, 0)
=> #<OpenStudio::Matrix:0x000055f2614156c8 @__swigtype__="_p_openstudio__Matrix">
[2] OpenStudio(main)> puts m
[4,4]((0,0,0,0),(0,0,0,0),(0,0,0,0),(0,0,0,0))
=> nil
[3] OpenStudio(main)> t = OpenStudio::Transformation.new
=> #<OpenStudio::Transformation:0x000055f2612f4398 @__swigtype__="_p_openstudio__Transformation">
[4] OpenStudio(main)> puts t
#<OpenStudio::Transformation:0x000055f2612f4398>
  • TODO: DO not merge yet, I think I may have a precision issue.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

Did that during interactive debugging for the Space PR, so upstreaming the changes
@jmarrec jmarrec added Enhancement Request Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings component - Python bindings labels Oct 19, 2021
@jmarrec jmarrec self-assigned this Oct 19, 2021
@tijcolem tijcolem merged commit e3ccb4e into develop Nov 19, 2021
@tijcolem tijcolem deleted the Matrix__str__ branch November 19, 2021 17:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component - Python bindings component - Ruby bindings Enhancement Request Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants