Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #2941 - Add option to show workflow run stdout + style + timings #4504

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Nov 18, 2021

Pull request overview

eg: openstudio run --show-stdout --add-timings --style-stdout -w example_model/workflow.osw

2941_Cli_Stdout

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

eg: `openstudio run --show-stdout --add-timings --style-stdout -w example_model/workflow.osw`
@jmarrec jmarrec added severity - Normal Bug Enhancement Request component - CLI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Nov 18, 2021
@jmarrec jmarrec requested a review from tijcolem November 18, 2021 15:49
@jmarrec jmarrec self-assigned this Nov 18, 2021
@tijcolem
Copy link
Collaborator

@jmarrec very cool and useful.

@tijcolem tijcolem merged commit c570e4b into develop Nov 19, 2021
@tijcolem tijcolem deleted the show_eplus_stdout branch November 19, 2021 20:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component - CLI Enhancement Request Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Normal Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't show E+ stdout when running from CLI
3 participants