Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FSI CI Test Improvement #58

Merged
merged 8 commits into from
Oct 7, 2024
Merged

FSI CI Test Improvement #58

merged 8 commits into from
Oct 7, 2024

Conversation

eyoung55
Copy link
Collaborator

@eyoung55 eyoung55 commented Mar 28, 2024

  • Add a static flag2d mesh to read during the CI test, this avoids issues with minor version changes in Gmsh producing minor variations during mesh generations resulting in minor deviations in the solution
  • Don't write the mesh again after the build() step, since it will be written during the build process as part of the write-to-read step which distributes cells equally across processes
  • Add back in an assertion that the solved lift/drag must match the truth vals

closes #54

@eyoung55 eyoung55 requested a review from arswalid March 28, 2024 23:04
@eyoung55
Copy link
Collaborator Author

The problem wasn't exactly that there was some bug or difference between (1) building a mesh and running that simulation vs. (2) reading in a copy of the same mesh and then running the simulation. The issue was that when not reading the mesh, the process was two steps: build() and then write_mesh_files(). But this call to write_mesh_files() led to problems, since as part of building, the mesh will be written and read automatically as part of distributing the cells.

So, building looked like:

  1. create geometry
  2. create original mesh
  3. write original mesh
  4. read original mesh (redistributes cells)
  5. over-write mesh (with now redistributed cells)

Such that a subsequent attempt to reproduce the same simulation read in the over-written mesh with the redistributed cells, and potential discrepancies.

@eyoung55 eyoung55 added this to the FY24 Release milestone Oct 7, 2024
Copy link
Collaborator

@arswalid arswalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to avoid redundant mesh writing, all tests pass. 1 conflict in test_solve.py resolved

@arswalid arswalid merged commit b9c12a3 into NREL:dev Oct 7, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants