Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add new references code, query error handling #29

Merged
merged 6 commits into from
Sep 17, 2024
Merged

add new references code, query error handling #29

merged 6 commits into from
Sep 17, 2024

Conversation

spodgorny9
Copy link
Collaborator

No description provided.

@spodgorny9 spodgorny9 force-pushed the sp/refs_cleanup branch 2 times, most recently from 2a77854 to 5940aad Compare September 13, 2024 16:35
@spodgorny9 spodgorny9 force-pushed the sp/refs_cleanup branch 5 times, most recently from fd0b39b to a1bad08 Compare September 13, 2024 18:19
@spodgorny9 spodgorny9 requested a review from ppinchuk September 13, 2024 18:57
ppinchuk
ppinchuk requested changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A couple of requests/questions here and there:

.github/workflows/pytest_postgres.yml Outdated Show resolved Hide resolved
.github/workflows/pytest_postgres.yml Outdated Show resolved Hide resolved
elm/web/rhub.py Outdated Show resolved Hide resolved
elm/web/rhub.py Outdated Show resolved Hide resolved
elm/web/rhub.py Show resolved Hide resolved
elm/wizard.py Outdated Show resolved Hide resolved
elm/wizard.py Outdated Show resolved Hide resolved
elm/wizard.py Show resolved Hide resolved
elm/wizard.py Show resolved Hide resolved
elm/wizard.py Show resolved Hide resolved
@spodgorny9 spodgorny9 force-pushed the sp/refs_cleanup branch 2 times, most recently from 37b7375 to d335925 Compare September 16, 2024 21:56
@spodgorny9 spodgorny9 requested a review from ppinchuk September 16, 2024 22:48
ppinchuk
ppinchuk requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great updates, thanks! A couple leftover minor ones and then we can merge!

elm/web/rhub.py Show resolved Hide resolved
tests/test_wizard_postgres.py Outdated Show resolved Hide resolved
tests/test_wizard_postgres.py Outdated Show resolved Hide resolved
tests/test_wizard_postgres.py Outdated Show resolved Hide resolved
@spodgorny9 spodgorny9 requested a review from ppinchuk September 17, 2024 14:29
ppinchuk
ppinchuk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@spodgorny9 spodgorny9 merged commit 090f828 into main Sep 17, 2024
12 of 15 checks passed
@spodgorny9 spodgorny9 deleted the sp/refs_cleanup branch September 17, 2024 15:27
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@spodgorny9
Merge pull request #29 from NREL/sp/refs_cleanup
a0755d8 
add new references code, query error handling
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ppinchuk ppinchuk ppinchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spodgorny9 @ppinchuk