Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Propane fuel not handled correctly #1100

Closed
shorowit opened this issue Jun 3, 2021 · 1 comment
Closed

Propane fuel not handled correctly #1100

shorowit opened this issue Jun 3, 2021 · 1 comment
Labels
severity - Minor Bug

Comments

@shorowit
Copy link

shorowit commented Jun 3, 2021

OS-standards is still requiring the older convention of 'PropaneGas' for propane fuel. When e.g. a boiler is created, it uses this string directly which is incompatible with the OS/E+ IDD, so the boiler incorrectly ends up with natural gas fuel (the default).

Two possibilities:

  1. Continue to require 'PropaneGas', but convert it to 'Propane' as needed for E+.
  2. Change all instances in the code from 'PropaneGas' to 'Propane'.
@shorowit shorowit mentioned this issue Jun 3, 2021
Merged
9 tasks
@shorowit shorowit mentioned this issue Oct 22, 2021
Closed
mdahlhausen added a commit that referenced this issue Mar 28, 2022
@mdahlhausen
add handling for propane
1cabbba 
Add handling for propane as a heating fuel type accounting for the fuel name adjustments in #1100
@mdahlhausen mdahlhausen mentioned this issue Mar 28, 2022
Merged
@mdahlhausen
Copy link
Collaborator

Addressed with #1292.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
severity - Minor Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdahlhausen @shorowit