Building Energy Standards Exterior Lighting Data Update #1896
Conversation
lymereJ
changed the title
…istent with the table name.
| occupancy_setback_reduction = exterior_lighting_properties['occupancy_setback_reduction'] | ||
| end | ||
| else | ||
| unless ['90.1-2004', '90.1-2007', 'DOE Ref Pre-1980', 'DOE Ref 1980-2004', 'DEER 1985', 'DEER 1996', 'DEER 2003', 'DEER 2007', 'DEER Pre-1975'].include?(template) |
There was a problem hiding this comment.
make an inclusive criteria, not an exclusive one. There are several other standards ignored here.
There was a problem hiding this comment.
Which ones are missing? I can certainly do that but there are a lot of applicable ones as well.
There was a problem hiding this comment.
other DEER versions, the NZE templates. I'm wondering if this should go back to being something in the standard fields? If it toggles on the standard, it should probably go in there.
There was a problem hiding this comment.
What other DEER versions? I see that the ones not listed there are using 0.3. Same for NZE. I'm not sure I understand what you mean by being in the standard fields, are you able to give an example?
| } | ||
| exterior_lighting_parking_req = standards_lookup_table_first(table_name: 'exterior_lighting', search_criteria: search_criteria) | ||
| power = exterior_lighting_parking_req['allowance'] | ||
| if exterior_lighting_parking_req['allowance_unit'] == 'W' |
There was a problem hiding this comment.
in what instance is the allowance in watts?
There was a problem hiding this comment.
One example is the base allowance.
There was a problem hiding this comment.
Makes sense for base allowance. It seems like this switch statement applies to all lighting types. A lot of duplicate code. It's not necessary in parking and most others, because all standard entries are in W/ft2. I can handle the cleanup unless there is a way you'd prefer to do it.
There was a problem hiding this comment.
I removed the statements and also clarified the names of the definitions to be more in line with the inputs.
Updates have been made to the Building Energy Standards Data repository, see here. This pull request was automatically generated.