Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Nrcan 404 - unit test update #1901

Open
wants to merge 250 commits into
base: nrcan
Choose a base branch
from
Open

Nrcan 404 - unit test update #1901

wants to merge 250 commits into from
+2,231,102 −298,136

Conversation

IainMacdonald
Copy link
Contributor

Pull request overview

Update to NECB unit tests:

  • Uses new test format using template design pattern.
  • Standardizes output file naming (output in json, old csv files removed)
  • Adds references for which part of NECB is being tested/exercised
  • Some CI tests have been commented out as they rely on subsequent merges

Update to ASHRAE 90.1:2019 prm data files

  • Removed long dashes from text strings in json data file (replaced with single -). These tests now work/pass.

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • All related changes have been implemented: method additions, changes, tests
  • CI status: all green or justified
    CI passing on branch but not develop - not sure why.

IainMacdonald and others added 30 commits October 12, 2023 11:40
@IainMacdonald
enabling comparison of two hash variables in unit testing
ee94dea
@IainMacdonald
WIP: reorg to use hashdiff
eb0a268
@IainMacdonald
template unit test class
b31033f
@IainMacdonald
WIP new json expected and test results (will remove test results later)
0b6f4fa
WIP adding json structure to tests
d4d4e5a
@IainMacdonald
progress on json files for expected results
e70076f
WIP
c929c02
@IainMacdonald
progress on json files for expected results
ef7bf15
@IainMacdonald
progress on json files for expected results
133519d
updated json - vartype added
1a7c6b6
@IainMacdonald
adding logging
6df06d8
@IainMacdonald
updating logging
c27981c
@IainMacdonald
updated testing structure to increase flexability and logging
3d9f119
@IainMacdonald
test set-up structure and results reporting working for two tests
d7bf6b4
@IainMacdonald
expected results for new format
58bc37e
@IainMacdonald
fixing :References and adding boiler curve helper method
609feac
@IainMacdonald
enabling more tests and updating logging
9de64cc
@IainMacdonald
updated expected results
494f064
@IainMacdonald
final expected results files for boiler tests
3e4c817
@IainMacdonald
adding gitignore for test results files (and removing previously save…
9f415d8 
…d ones)
@IainMacdonald
adding gitignore for results files
ca07ec2
@IainMacdonald
completed update to new structure
3e27d4a
@IainMacdonald
removing old results files
2260a08
@IainMacdonald
fixing hash keys to all be symbols - required for assert checking
360e790
@IainMacdonald
minor clean up of unused code
d4dd6d5
@IainMacdonald
removing gems and including equivalent code
b6c3dcd
@IainMacdonald
adding digits to ensure correct conversion to metric
eeb4d30
@IainMacdonald
WIP updating to use new process
9edb7fd
@IainMacdonald
updated chiller data and tests
8ffb6b5
@IainMacdonald
removing old expected results (data now in json file)
584d62a
@IainMacdonald
fixing method call, unit test now passes
bbf2b20
@IainMacdonald
adding references and minor clean up of code
7c0a51f
@IainMacdonald
adding method used in tests to create geometry only
ac7f123
@IainMacdonald
using new helper method to create geometry
e00a420
@IainMacdonald
updated test - only checking spacetypes used in reference models
18bc0fa
@IainMacdonald
updated test - only checking spacetypes used in reference models
f5df981
@IainMacdonald
clean up to remove unnecessary NECB rules
755faee
@IainMacdonald
minor - updaing comment
9f3aa39
@IainMacdonald
minor - updaing comment
9e71110
@IainMacdonald
updated weather hdd test
4a8d26f
@IainMacdonald
removing unnecessary files
f045f22
@IainMacdonald
merged nrcan branch and resolved conflicts
433c6eb
@IainMacdonald
replaced by test_ecm_swh.rb
bf0dec1
@IainMacdonald
updating call to setup_hw_loop_with_components (missed these ones dur…
4ed35bc 
…ing merge)
@IainMacdonald
updatig call to run_sizing
a3571c1
@IainMacdonald
updating call post merge
39d37c8
@IainMacdonald
minor variations to expected results post merge of nrcan branch
4c515e6
@IainMacdonald
missing expected results
f930d77
@IainMacdonald
fixing test post merge from nrcan branch
4e4c3f9
@IainMacdonald
fixing method calls post nrcan branch merge
7834140
@IainMacdonald
updating to new format
4878912
@IainMacdonald
clean up of test code, moved model loading out of loop - much faster now
c334c33
@IainMacdonald
updating test file name so gitignore rule works on them
4fc2cf1
@IainMacdonald
new format expected results file
c5038d2
@IainMacdonald
reverting files back to nrcan branch version
deb3418
@IainMacdonald
commenting out failing tests
c8e62c4
@IainMacdonald
commenting out test
01d57a0
@IainMacdonald
fixing long dashes in file (making them short ones)
e5c1b30
@IainMacdonald
Copy link
Contributor Author

@ckirney the other 404 branches will be merged on top of this one (they currently contain these changes too so the merges look way more complicated than they are). By the end of the updates all the unit tests will be active.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@ckirney ckirney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IainMacdonald @ckirney @MarianaNRC