Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/water heater update #513

Merged
merged 10 commits into from
Dec 10, 2020
Merged

Feature/water heater update #513

merged 10 commits into from
Dec 10, 2020

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Nov 23, 2020

Pull Request Description

Companion PR: resstock-estimation #87

This pull request updates the water heater housing characteristics.

Current Structure

  • A single housing characteristic Water Heater.tsv.
  • We currently do not model premium water heater options.
  • We currently do not model heat pump water heaters.

New Structure

  • New housing characteristics Water Heater In Unit.tsv that is used to potentially separate out energy for central water heaters.
  • The Water Heater.tsv is split into 2 housing characteristics.
    • Water Heater Fuel.tsv: The fuel of the water heater.
    • Water Heater Efficiency.tsv: The efficiency and type (tank/tankless) of the water heater

New options being modeled

  • Water heater blanket is used as a proxy for premium storage tank water heaters.
  • Heat pump water heaters are now modeled and are 0.5% of the electric water heaters in the stock except in the Pacific Northwest (CR06) where they are 3% of the electric water heaters.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson joseph-robertson changed the base branch from master to develop December 8, 2020 17:28
@afontani afontani marked this pull request as ready for review December 8, 2020 20:07
@afontani afontani requested a review from ejhw December 9, 2020 03:51
@afontani afontani merged commit 5553552 into develop Dec 10, 2020
@afontani afontani deleted the feature/water_heater_update branch December 10, 2020 23:38
@joseph-robertson joseph-robertson added this to the ResStock v2.4.0 milestone Dec 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants